Gate client-side media processing as plugin-only#76700
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| // Client-side media processing is currently plugin-only while the feature matures. | ||
| if ( ! defined( 'IS_GUTENBERG_PLUGIN' ) || ! IS_GUTENBERG_PLUGIN ) { | ||
| return; |
There was a problem hiding this comment.
Thanks for prepping this PR!
Just checking, I set define( 'IS_GUTENBERG_PLUGIN', false ); and it does stop here. 👍🏻
But I noticed that window.__clientSideMediaProcessing is still true and worker.js loads when I upload an image. Is that expected?
There was a problem hiding this comment.
How did you test this? Is that because the core patch hasn't landed yet?
Client-side media processing (wasm-vips) adds ~16MB of WASM to the build. Gate the feature behind IS_GUTENBERG_PLUGIN so it remains active in the plugin but is excluded when syncing to WordPress core, reducing core bundle size.
ba77c55 to
675f005
Compare
|
I rebased to restart the tests. The 26 failures were the same as the ones earlier in trunk. I'm going to force a merge since there is time pressure for Beta 6. We can double check the tests during the code freeze. |
Client-side media processing (wasm-vips) adds ~16MB of WASM to the build. Gate the feature behind IS_GUTENBERG_PLUGIN so it remains active in the plugin but is excluded when syncing to WordPress core, reducing core bundle size. Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 2ee7ede |
|
Flaky tests detected in 675f005. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23344982432
|
This updates the pinned hash from the `gutenberg` from `487a096a9782ba6110a7686d7b4b2d0c55ed1b06` to `2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d`. The following changes are included: - RTC: Backport race condition fix (WordPress/gutenberg#76649) - Fix navigation block rendering unit test (WordPress/gutenberg#76685) - Hide Additional CSS controls when block is inside contentOnly editing mode (WordPress/gutenberg#76512) - RTC: Increase polling intervals, increase polling on primary room only (WordPress/gutenberg#76704) - Navigation: Avoid List View changing position when navigation block saves (WordPress/gutenberg#76659) - Fix navigation block unit test and e2e test (WordPress/gutenberg#76692) - Fix locked content when switching to a different template without exiting 'Edit pattern' (WordPress/gutenberg#76710) - Metabox: Fix checkbox style in sidebar (WordPress/gutenberg#76718) - Stop keeping stale controlled blocks after reset (WordPress/gutenberg#76591) - Gate client-side media processing as plugin-only (WordPress/gutenberg#76700) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/487a096a9782ba6110a7686d7b4b2d0c55ed1b06…2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d. Log created with: git log --reverse --format="- %s" 487a096a9782ba6110a7686d7b4b2d0c55ed1b06..2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62076 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `487a096a9782ba6110a7686d7b4b2d0c55ed1b06` to `2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d`. The following changes are included: - RTC: Backport race condition fix (WordPress/gutenberg#76649) - Fix navigation block rendering unit test (WordPress/gutenberg#76685) - Hide Additional CSS controls when block is inside contentOnly editing mode (WordPress/gutenberg#76512) - RTC: Increase polling intervals, increase polling on primary room only (WordPress/gutenberg#76704) - Navigation: Avoid List View changing position when navigation block saves (WordPress/gutenberg#76659) - Fix navigation block unit test and e2e test (WordPress/gutenberg#76692) - Fix locked content when switching to a different template without exiting 'Edit pattern' (WordPress/gutenberg#76710) - Metabox: Fix checkbox style in sidebar (WordPress/gutenberg#76718) - Stop keeping stale controlled blocks after reset (WordPress/gutenberg#76591) - Gate client-side media processing as plugin-only (WordPress/gutenberg#76700) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/487a096a9782ba6110a7686d7b4b2d0c55ed1b06…2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d. Log created with: git log --reverse --format="- %s" 487a096a9782ba6110a7686d7b4b2d0c55ed1b06..2ee7ede6be6d4e55d5c7047394c5c4e0ea8d521d | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/trunk@62076 git-svn-id: http://core.svn.wordpress.org/trunk@61358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This reverts commit d259aab.
Summary
IS_GUTENBERG_PLUGINso it only loads when running as the Gutenberg pluginChanges
lib/media/load.php: Early return whenIS_GUTENBERG_PLUGINis not defined, preventing all client-side media processing infrastructure (cross-origin isolation, JS flags, REST API modifications) from loading outside the pluginlib/client-assets.php: Gate thegutenberg_enqueue_vips_loaderaction hook behindIS_GUTENBERG_PLUGIN, preventing the vips script module from being enqueued outside the pluginTest plan
gutenberg_is_client_side_media_processing_enabled()still returns true in plugin context on secure origins