Column block: Migrate width to dimensions block support#76684
Draft
aaronrobertshaw wants to merge 1 commit intotrunkfrom
Draft
Column block: Migrate width to dimensions block support#76684aaronrobertshaw wants to merge 1 commit intotrunkfrom
aaronrobertshaw wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: +322 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #76525
Migrate the column block's custom
widthattribute to use thedimensions.widthblock support.Why?
The column block currently manages its own width attribute and a bespoke inspector control, separate from the standard design tooling infrastructure. Moving to block support aligns it with the rest of the system, makes column width available via theme.json and global styles, and removes custom UI code in favor of the existing dimensions panel.
Part of the 7.1 design tooling enhancements tracked in #76525.
How?
dimensions.widthsupport on the column block with__experimentalSkipSerialization-- the column lives in a flex container, so it needsflex-basisrather thanwidthin the rendered CSS.WP_Theme_JSON_GutenbergandtransformToStyles(global styles engine) so that theme.json styles resolve correctly for columns.widthattribute and theColumnInspectorControlspanel from the edit component.widthand older numericwidthboth migrate tostyle.dimensions.width).Testing Instructions
style.dimensions.widthrather than the top-levelwidthattribute.flex-basis(notwidth) is applied.Testing Instructions for Keyboard
Screenshots or screencast