Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +367 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3d76cc8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23427102941
|
Member
|
Error messages should be plain language, reassure you, and help you recover from error. I'd say this meets that criteria quite well. |
Contributor
Author
|
The downside here is that we're losing the actual "raw message" from the server, which can be confusing but also helpful to debug. So I wonder how we can either incorporate it somehow, alternatively we could just dump it into the console but it will be more hidden. |
Contributor
Author
|
Rich, what do you the messaging should be for publish/update errors. |
Member
I tried to do that as part of #64158, but eventually closed my PR - #68360 (comment). |
Member
What do you think of these: Publishing failed. Your content will be persisted locally to avoid content loss. Please try publishing again. |
Contributor
Author
|
They work for me, with the same caveat that they hide the actual error message that might help debugging. |
Append server error messages in an expandable <details> element on save failure notices, improve failure copy to mention local persistence and retry guidance, and add autosave-specific notice strings for both online and offline failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
I added a "show details" to show the raw error message in a modal to not lose the "debugging" possibilities. WDYT? I also updated all the messages. (save, publishing, scheduling and auto-save) |
Add the missing tsconfig.json reference for @wordpress/escape-html, fixing the lint:tsconfig CI check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Regenerate the lock file after adding @wordpress/escape-html to the editor package dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates editor autosave failure notices to use autosave-specific copy, explain local persistence and retry behavior, and avoid appending raw server error text.
Why?
Autosave failures currently fall back to the generic update failure notice, which is less clear in context and can append cryptic backend messages that are not actionable for most users.
How?
This passes save options into the save-failure notice builder so autosave requests can use dedicated notice strings for normal and offline failures, while preserving existing publish/update failure behavior. It also adds unit coverage for the autosave-specific notice path.
Testing Instructions
Auto-save failed. Your changes will be persisted locally to avoid content loss. We’ll retry automatically, or you can save manually.npm run test:unit -- packages/editor/src/store/utils/test/notice-builder.js --runInBand.Testing Instructions for Keyboard
Screenshots or screencast