Core Data: Fix selectors returning stale results for different 'per_page' queries#76422
Merged
Core Data: Fix selectors returning stale results for different 'per_page' queries#76422
Conversation
…age' queries Queries with different `per_page` values share the same `stableKey`, causing selectors to return cached items from a prior query instead of null while the new query resolves. Add a check in `getQueriedItemsUncached` that returns `null` when stored `itemIds` can't satisfy the requested pagination range and `totalItems` confirms more items exist.
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kozack-webspark. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
andrewserong,
jsnajdr,
ramonjd,
tyxla and
youknowriad
|
Size Change: +32 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Mar 12, 2026
| itemIds = state.queries[ context ][ stableKey ].itemIds; | ||
| } | ||
|
|
||
| const itemIds = state.queries?.[ context ]?.[ stableKey ]?.itemIds; |
Member
Author
There was a problem hiding this comment.
Unrelated. Just a minor cleanup.
|
Flaky tests detected in 8338e14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22991562546
|
ramonjd
reviewed
Mar 12, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
What magic is this?! I can confirm it fixes #56355
I also created 100 pages and couldn't find any regressions using the data views-driven page list in the site editor.
I'll yield the floor to @andrewserong, who reported the issue, and/or @jsnajdr to double check but it LGTM. Thank you!!
andrewserong
approved these changes
Mar 13, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
I'll yield the floor to @andrewserong, who reported the issue
Wow, that was so long ago, I can barely remember! 😄
I like the fix thanks for working on it @Mamaduka 👍
✅ If the per_page is smaller than the items we've already got, then the cached value is returned
✅ If the per_page is larger than the items we've already got, then we get null in the first call, and in subsequent calls we get the cached results
This feels like how I'd expect it to work, and nice that you came up with a way to fix it without changing the stableKey (returning null effectively means that the value won't be treated as cached, so the change here correctly increases the cache misses) 🎉
LGTM! 🚀
Member
Author
|
Thanks for testing and feedback, everyone 🙇 |
Contributor
|
Looks like we missed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #56355.
Queries with different
per_pagevalues share the samestableKey, causing selectors to return cached items from a prior query instead ofnullwhile the new query resolves. Add a check ingetQueriedItemsUncachedthat returnsnullwhen storeditemIdscan't satisfy the requested pagination range andtotalItemsconfirms more items exist.Note: The new guardrail might fail when
totalItemsand the query return stale data, but that should be very rare.How
Tries to fix the bug without changing the query
cacheKey.Testing Instructions
Testing Instructions for Keyboard
Same.