Guidelines: Refactor components and improve TypeScript typing#76394
Guidelines: Refactor components and improve TypeScript typing#76394im3dabasia merged 4 commits intoWordPress:trunkfrom
Conversation
Ref: #76155 (comment) I’m not sure what the best way to handle this is. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@andrewserong, @aagam-shah would appreciate your review on this PR when you get a chance |
|
@im3dabasia Thanks for the refactoring — the typed A few things:
|
|
@aagam-shah, I’m done addressing the feedback. I’d appreciate your review once you’re back. |
aagam-shah
left a comment
There was a problem hiding this comment.
Thanks for working on this! Code changes look good to me 🚢
aswasif007
left a comment
There was a problem hiding this comment.
Thanks for working on this!
23f4857 to
70237ce
Compare
|
I’ll go ahead with the merge. I rebased the PR to check if the failing tests would pass, though they seem unrelated. |
What?
Closes #76387
Refactors parts of the Content Guidelines implementation to improve component structure and TypeScript typing.
Why?
During the review of #76155 a few code quality improvements were identified, mainly around component readability and stronger typing.
How?
actions-sectioninto smaller components for better readability.STORE_NAMEto avoidas unknowncasts and improve type inference.Testing Instructions