Skip to content

Simplify require statements for navigation files#76373

Merged
scruffian merged 1 commit intotrunkfrom
update/require-shared-navigation-files
Mar 12, 2026
Merged

Simplify require statements for navigation files#76373
scruffian merged 1 commit intotrunkfrom
update/require-shared-navigation-files

Conversation

@scruffian
Copy link
Copy Markdown
Contributor

What?

Simplify the require statments for the navigation block

Why?

It's unnecessary to have different require statements for src, since we only ever load blocks from build.

How?

Remove the unused code

Testing Instructions

Check that the navigation block still uses these functions

@scruffian scruffian self-assigned this Mar 10, 2026
@scruffian scruffian added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Mar 10, 2026
@github-actions github-actions bot added the [Package] Block library /packages/block-library label Mar 10, 2026
@github-actions
Copy link
Copy Markdown

Flaky tests detected in 068301d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22914691548
📝 Reported issues:

Copy link
Copy Markdown
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering #76372 has landed, this is looking good!

@scruffian scruffian marked this pull request as ready for review March 12, 2026 09:53
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@scruffian scruffian merged commit c4391c0 into trunk Mar 12, 2026
52 checks passed
@scruffian scruffian deleted the update/require-shared-navigation-files branch March 12, 2026 10:03
@github-actions github-actions bot added this to the Gutenberg 22.8 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Affects the Navigation Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants