Repository navigation
Icon block: Fix icons becoming too small when padding is applied - #76295
kannan-ravi wants to merge 1 commit into
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kannan-ravi! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks for the PR! Before moving forward with this PR, let's discuss whether the current behavior is truly a bug. See #76288 (comment) |
|
+1 to holding off on this PR until the discussion over on #76288 (comment) runs its course. Especially given that the user still has full control on the width and presentation of the Icon block for the moment. By that I mean, if a user sets a width on a block, then adds too much padding or border width to eat up that space, they can adjust the width to suit. I suspect the issue is more with the scenario that the user has just accepted the default width and not made an active selection. |
|
@kannan-ravi, I'd like to close this PR based on #76288 (comment), but thanks for your efforts! |
What?
Closes #76288
Fix icons becoming too small when padding is applied to the icon block by changing SVG box-sizing from border-box to content-box.
Why?
When users added padding to icon blocks, the SVG icons would become too small because they were using border-box sizing, which included the wrapper's padding in the size calculation.
How?
Changed SVG box-sizing from border-box to content-box in
.wp-block-icon svg.Testing Instructions
Screenshots or screencast
Before
Before.mp4
After
After.mp4