RTC: Show own presence indicators (as a preference)#76270
Closed
chriszarate wants to merge 1 commit intotrunkfrom
Closed
RTC: Show own presence indicators (as a preference)#76270chriszarate wants to merge 1 commit intotrunkfrom
chriszarate wants to merge 1 commit intotrunkfrom
Conversation
chriszarate
added
[Type] Task
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Editor
|
Size Change: +307 B (0%) Total Size: 6.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8d6a61c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22882562873
|
chriszarate
force-pushed
the
feat/self-presence
branch
from
f77ee26 to
8d6a61c
Compare
ingeniumed
approved these changes
Mar 11, 2026
| .filter( ( userState: ActiveCollaborator ) => { | ||
| const shouldDrawUser = | ||
| ! userState.isMe || | ||
| ( showOwnCursor && hasOtherCollaborators ); |
Contributor
There was a problem hiding this comment.
Based on this, shouldn't the comment on line 89 be
// When there are no other collaborators, we shouldn't show the user's own
// selection even if the preference is enabled.
Contributor
Author
|
Closing in favor of #76413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add an editor preference to show the current user's presence indicators during a collaborative session.
Closes #75838
Why?
User feedback has been mixed, but some users have a strong expectation that all users in a collaborative session should receive consistent presence indicators.
How?
Update the presence logic to conditionally show the current user's presence indicators.
Testing Instructions
Screenshots or screencast
self-presence.mov
paging @dabowman for design review