RTC: Fix 'networkidle' and other e2e tests that are flaky#76214
Merged
alecgeatches merged 3 commits intotrunkfrom Mar 6, 2026
Merged
RTC: Fix 'networkidle' and other e2e tests that are flaky#76214alecgeatches merged 3 commits intotrunkfrom
alecgeatches merged 3 commits intotrunkfrom
Conversation
alecgeatches
added
[Feature] Real-time Collaboration
chriszarate
reviewed
Mar 5, 2026
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 550d31b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22780031201
|
chriszarate
force-pushed
the
fix/networkidle-on-rtc
branch
from
0d683fa to
94b17f8
Compare
…with RTC in the editor
alecgeatches
force-pushed
the
fix/networkidle-on-rtc
branch
from
94b17f8 to
abe4ee8
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
maxschmeling
approved these changes
Mar 6, 2026
alecgeatches
changed the title
alecgeatches
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove
await page.waitForLoadState( 'networkidle' )from end-to-end tests.Why?
Now that real-time collaboration is turned on by default, the
networkidlestate is a lot more flaky. Once RTC has connected via the default transport, it's constantly sendingPOST /wp-sync/v1/updatecalls, meaning that we may not hit a period ofnetworkidleduring tests. These tests will eventually time out.How?
The only two
networkidleuses in e2e tests appear to be workarounds for previous flaky results. We've tried to use another method and await something else instead in both cases.Testing Instructions