HTML & Shortcode: Disable viewport visibility support by sagarjadhav · Pull Request #76138 · WordPress/gutenberg

sagarjadhav · 2026-03-04T11:30:05Z

What?

Explicitly disables viewport visibility support for the Custom HTML and Shortcode blocks.

Why?

Viewport visibility relies on wrapper-level class injection via block supports.
The core/html block disables className support and does not render a wrapper element in save, meaning the responsive hide CSS has no DOM target.

As a result, the visibility controls appear in the UI but do not function correctly for this block.

Since modifying the block to inject a wrapper would introduce markup changes and potential backward-compatibility concerns, this PR aligns block capabilities with its rendering behavior by opting out of viewport visibility support.

How?

This PR adds the following to packages/block-library/src/html/block.json:

"visibility": false

This explicitly disables viewport visibility support for the HTML block while leaving other blocks unaffected.

No changes to rendering logic or frontend markup were introduced.

Testing Instructions

Checkout this branch.
Run npm install (if needed).
Run npm run build.
Start a local WordPress environment with Gutenberg active.
Open a post or page.
Insert a Custom HTML block.
Check the block settings sidebar.

Expected result:

The viewport visibility controls (e.g., “Hide on Desktop”) should no longer appear for the Custom HTML block.

Verification:

Insert a Paragraph block.
Confirm viewport visibility controls are still available for that block.
Confirm no frontend markup changes occur for the HTML block.

Testing Instructions for Keyboard

Open a post or page.
Use /html to insert a Custom HTML block.
Press Shift + Tab to move to the block settings sidebar.
Navigate through available controls using Tab.

Expected result:

No viewport visibility controls should be present for the Custom HTML block.
Keyboard navigation should remain unaffected.

Screenshots or screencast

Before

Visibility controls visible but non-functional for Custom HTML block.

After

Visibility controls no longer displayed for Custom HTML block.

|

github-actions · 2026-03-04T11:30:17Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sagarjadhav <sagarjadhav@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-03-04T11:30:48Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sagarjadhav! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Mamaduka

Thanks, @sagarjadhav!

This matches the support configuration of similar blocks.

I think the same changes need to be made for the Shortcodes block as well. Do you mind including it in this PR? See packages/block-library/src/shortcode/block.json?

shimotmk · 2026-03-04T11:54:49Z

Should disable all visibility? I thought I needed a way to disable only the viewport, as "Omit from published content" is working.

Mamaduka · 2026-03-04T11:58:01Z

Should disable all visibility? I thought I needed a way to disable only the viewport, as "Omit from published content" is working.

It's worth double-checking. I scanned other blocks with no containers, and they seem to fully disable the feature. Though it might be for different reasons.

cc @t-hamano, @ramonjd

sagarjadhav · 2026-03-04T12:35:01Z

@Mamaduka Thanks! I’ve added the same change for the Shortcode block as well.

t-hamano · 2026-03-04T13:27:12Z

Viewport-based visibility support should work as long as the block has a root element, because the HTML Tag Processor injects CSS classes into the root element.

However, the Custom HTML block and the Shortcode block don't necessarily have any element rendered at the root.

Unfortunately, it's not possible to disable only some aspects of visibility support, so I think it's best to disable visibility support completely for the Custom HTML block and the Shortcode block.

I scanned other blocks with no containers, and they seem to fully disable the feature. Though it might be for different reasons.

I recll one reason this support is disabled for some blocks is that it doesn't work if the block content is processed before the render_block hook runs. See #74439 (comment)

t-hamano · 2026-03-04T14:22:14Z

@sagarjadhav, could you update the PR title and description to reflect that this PR includes changes to two blocks, Shortcode and Custom HTML?

Mamaduka

Updated the title and description. Let's merge this. We can re-enable partial visibility features when support flags allow it.

Co-authored-by: sagarjadhav <sagarjadhav@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: shimotmk <shimotomoki@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>

github-actions · 2026-03-04T14:40:01Z

I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: f757d7f

ramonjd · 2026-03-05T02:08:18Z

thanks for catching these folks!

CI run: WordPress#11167. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 022d8dd3d461f91b15c1f0410649d3ebb027207f..e499abfb843a43ac88455ca319220c5f181e1cf3 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Add documentation for contentRole and listView block supports (WordPress/gutenberg#75903) - Interactivity Router: fix back and forward navigation after refresh (WordPress/gutenberg#75927) - Real-time collaboration: Fix disconnect dialog on navigate (WordPress/gutenberg#75886) - Real Time Collab: Throttle syncing for inactive tabs. (WordPress/gutenberg#75843) - Components: Specify line-height to avoid inheriting default values (WordPress/gutenberg#75880) - Pattern Editing: Fix sibling blocks to edited pattern not being disabled (WordPress/gutenberg#75994) - Sync connector PHP behavior with Core backport changes (WordPress/gutenberg#75968) - Connectors: Avoid manual string concatenation (WordPress/gutenberg#75997) - DataForm: fix field label for panel (should not be uppercase) (WordPress/gutenberg#75944) - Views: add support for more overrides (all developer-defined config) (WordPress/gutenberg#75971) - Use homeUrl instead of siteUrl for link badge evaluations (WordPress/gutenberg#75978) - DataViews: Right-align `integer` and `number` fields (WordPress/gutenberg#75917) - Navigation Link: Compare internal links by host instead of origin (WordPress/gutenberg#76015) - Fix: Skip scaled image sideload for images below big image threshold (WordPress/gutenberg#75990) - Client side media cherry pick for 7.0 (WordPress/gutenberg#75998) - Show transform dropdown previews on focus as well as hover (WordPress/gutenberg#75940) (WordPress/gutenberg#75992) - RTC: Fix syncing of emoji / surrogate pairs (WordPress/gutenberg#76049) - [Real-time Collaboration] Fix sync issue on refresh (WordPress/gutenberg#76017) - Real-time collaboration: Improve disconnect dialog (WordPress/gutenberg#75970) - DataViews: Fix filter toggle flickering when there are locked or primary filters (WordPress/gutenberg#75913) (WordPress/gutenberg#76068) - Connectors: Dynamically register providers from WP AI Client registry (WordPress/gutenberg#76014) - PHP-only Blocks: Reflect bound attribute values in inspector controls (WordPress/gutenberg#76040) - Fix: Set quality and strip metadata in client-side image resize (WordPress/gutenberg#76029) - RTC: Prevent duplicate poll cycles (WordPress/gutenberg#76059) - RTC: Fix stale CRDT document persisted on save (WordPress/gutenberg#75975) - RTC: Disable multiple collaborators if meta boxes are present (WordPress/gutenberg#75939) - Directly inject styles in overlay to make styles stay consistently mounted (WordPress/gutenberg#75700) - Real-time collaboration: Fix comment syncing on site editor (WordPress/gutenberg#75746) - Real-time Collaboration: Bug fix for CRDT user selection and add tests (WordPress/gutenberg#75075) - RTC: Updates from backport PR (WordPress/gutenberg#75711) - RTC: Fix undefined array_first() call in sync storage (WordPress/gutenberg#75869) - RTC: Fix fallthrough for sync update switch statement (WordPress/gutenberg#76060) - Real-time collaboration: Remove block client IDs from Awareness, fix "Show Template" view (WordPress/gutenberg#75590) - RTC: Add session activity notifications (WordPress/gutenberg#76065) - Prevent non-reproducible Sass/CSS builds. (WordPress/gutenberg#76098) - Block toolbar and context menu: hide pattern actions in Revisions UI (WordPress/gutenberg#76066) - Try enabling style variation transforms for blocks in contentOnly mode (WordPress/gutenberg#75761) - Block toolbar: hide styles dropdown in Revisions UI (WordPress/gutenberg#76119) - Image block: fix lightbox srcset size (WordPress/gutenberg#76092) - Fix writing flow navigation for annotation style, or any other block with border radius (WordPress/gutenberg#76072) - Image: Hide 'Set as featured image' for in-editor revisions (WordPress/gutenberg#76123) - Connectors: Gate unavailable install actions behind install capability (WordPress/gutenberg#75980) - build: Exclude experimental pages from Core builds (WordPress/gutenberg#76038) - HTML & Shortcode: Disable viewport visibility support (WordPress/gutenberg#76138) - RTC: Verify client ID to avoid awareness mutation (WordPress/gutenberg#76056) - wp-build: Do not remove Core's default script modules registration (WordPress/gutenberg#75705) - wp-build: Deregister script modules before re-registering (WordPress/gutenberg#75909) - Remove `! function_exists()` checks from PHP templates (WordPress/gutenberg#76062) - Connectors: Update page identifier to options-connectors (WordPress/gutenberg#76156) - Connectors: Align init hook priorities with Core overrides (WordPress/gutenberg#76161) - Icon Block: Clean up selectors config (WordPress/gutenberg#75786) - Icons: Fix incorrect icon slug (WordPress/gutenberg#76165) - RTC: Enable RTC by default (WordPress/gutenberg#75739) - Rename and visibility modals: gate shortcuts behind canEditBlock to prevent triggering in revisions UI (WordPress/gutenberg#76168) - Fix: Block style variations not rendering in Site Editor Patterns page (WordPress/gutenberg#76122) - Client-side media processing: only use media upload provider when not in preview mode (WordPress/gutenberg#76124) - Notes: Disable for in-editor revisions (WordPress/gutenberg#76180) - Core Data: Support reading revision data in useEntityProp (fixes footnotes in revisions UI) (WordPress/gutenberg#76106) - Client-side media processing: Try plumbing invalidation to the block-editor's mediaUpload onSuccess callback (WordPress/gutenberg#76173) - Connectors: Improve responsive layout on small screens (WordPress/gutenberg#76186) - Interactivity API: Fix router initialization race condition on Safari/Firefox (WordPress/gutenberg#76053) (WordPress/gutenberg#76191) - Interactivity: Fix crypto.randomUUID crash in non-secure contexts (WordPress/gutenberg#76151) git-svn-id: https://develop.svn.wordpress.org/trunk@61843 602fd350-edb4-49c9-b593-d223f7449a82

CI run: WordPress/wordpress-develop#11167. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 022d8dd3d461f91b15c1f0410649d3ebb027207f..e499abfb843a43ac88455ca319220c5f181e1cf3 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Add documentation for contentRole and listView block supports (WordPress/gutenberg#75903) - Interactivity Router: fix back and forward navigation after refresh (WordPress/gutenberg#75927) - Real-time collaboration: Fix disconnect dialog on navigate (WordPress/gutenberg#75886) - Real Time Collab: Throttle syncing for inactive tabs. (WordPress/gutenberg#75843) - Components: Specify line-height to avoid inheriting default values (WordPress/gutenberg#75880) - Pattern Editing: Fix sibling blocks to edited pattern not being disabled (WordPress/gutenberg#75994) - Sync connector PHP behavior with Core backport changes (WordPress/gutenberg#75968) - Connectors: Avoid manual string concatenation (WordPress/gutenberg#75997) - DataForm: fix field label for panel (should not be uppercase) (WordPress/gutenberg#75944) - Views: add support for more overrides (all developer-defined config) (WordPress/gutenberg#75971) - Use homeUrl instead of siteUrl for link badge evaluations (WordPress/gutenberg#75978) - DataViews: Right-align `integer` and `number` fields (WordPress/gutenberg#75917) - Navigation Link: Compare internal links by host instead of origin (WordPress/gutenberg#76015) - Fix: Skip scaled image sideload for images below big image threshold (WordPress/gutenberg#75990) - Client side media cherry pick for 7.0 (WordPress/gutenberg#75998) - Show transform dropdown previews on focus as well as hover (WordPress/gutenberg#75940) (WordPress/gutenberg#75992) - RTC: Fix syncing of emoji / surrogate pairs (WordPress/gutenberg#76049) - [Real-time Collaboration] Fix sync issue on refresh (WordPress/gutenberg#76017) - Real-time collaboration: Improve disconnect dialog (WordPress/gutenberg#75970) - DataViews: Fix filter toggle flickering when there are locked or primary filters (WordPress/gutenberg#75913) (WordPress/gutenberg#76068) - Connectors: Dynamically register providers from WP AI Client registry (WordPress/gutenberg#76014) - PHP-only Blocks: Reflect bound attribute values in inspector controls (WordPress/gutenberg#76040) - Fix: Set quality and strip metadata in client-side image resize (WordPress/gutenberg#76029) - RTC: Prevent duplicate poll cycles (WordPress/gutenberg#76059) - RTC: Fix stale CRDT document persisted on save (WordPress/gutenberg#75975) - RTC: Disable multiple collaborators if meta boxes are present (WordPress/gutenberg#75939) - Directly inject styles in overlay to make styles stay consistently mounted (WordPress/gutenberg#75700) - Real-time collaboration: Fix comment syncing on site editor (WordPress/gutenberg#75746) - Real-time Collaboration: Bug fix for CRDT user selection and add tests (WordPress/gutenberg#75075) - RTC: Updates from backport PR (WordPress/gutenberg#75711) - RTC: Fix undefined array_first() call in sync storage (WordPress/gutenberg#75869) - RTC: Fix fallthrough for sync update switch statement (WordPress/gutenberg#76060) - Real-time collaboration: Remove block client IDs from Awareness, fix "Show Template" view (WordPress/gutenberg#75590) - RTC: Add session activity notifications (WordPress/gutenberg#76065) - Prevent non-reproducible Sass/CSS builds. (WordPress/gutenberg#76098) - Block toolbar and context menu: hide pattern actions in Revisions UI (WordPress/gutenberg#76066) - Try enabling style variation transforms for blocks in contentOnly mode (WordPress/gutenberg#75761) - Block toolbar: hide styles dropdown in Revisions UI (WordPress/gutenberg#76119) - Image block: fix lightbox srcset size (WordPress/gutenberg#76092) - Fix writing flow navigation for annotation style, or any other block with border radius (WordPress/gutenberg#76072) - Image: Hide 'Set as featured image' for in-editor revisions (WordPress/gutenberg#76123) - Connectors: Gate unavailable install actions behind install capability (WordPress/gutenberg#75980) - build: Exclude experimental pages from Core builds (WordPress/gutenberg#76038) - HTML & Shortcode: Disable viewport visibility support (WordPress/gutenberg#76138) - RTC: Verify client ID to avoid awareness mutation (WordPress/gutenberg#76056) - wp-build: Do not remove Core's default script modules registration (WordPress/gutenberg#75705) - wp-build: Deregister script modules before re-registering (WordPress/gutenberg#75909) - Remove `! function_exists()` checks from PHP templates (WordPress/gutenberg#76062) - Connectors: Update page identifier to options-connectors (WordPress/gutenberg#76156) - Connectors: Align init hook priorities with Core overrides (WordPress/gutenberg#76161) - Icon Block: Clean up selectors config (WordPress/gutenberg#75786) - Icons: Fix incorrect icon slug (WordPress/gutenberg#76165) - RTC: Enable RTC by default (WordPress/gutenberg#75739) - Rename and visibility modals: gate shortcuts behind canEditBlock to prevent triggering in revisions UI (WordPress/gutenberg#76168) - Fix: Block style variations not rendering in Site Editor Patterns page (WordPress/gutenberg#76122) - Client-side media processing: only use media upload provider when not in preview mode (WordPress/gutenberg#76124) - Notes: Disable for in-editor revisions (WordPress/gutenberg#76180) - Core Data: Support reading revision data in useEntityProp (fixes footnotes in revisions UI) (WordPress/gutenberg#76106) - Client-side media processing: Try plumbing invalidation to the block-editor's mediaUpload onSuccess callback (WordPress/gutenberg#76173) - Connectors: Improve responsive layout on small screens (WordPress/gutenberg#76186) - Interactivity API: Fix router initialization race condition on Safari/Firefox (WordPress/gutenberg#76053) (WordPress/gutenberg#76191) - Interactivity: Fix crypto.randomUUID crash in non-secure contexts (WordPress/gutenberg#76151) Built from https://develop.svn.wordpress.org/trunk@61843 git-svn-id: http://core.svn.wordpress.org/trunk@61130 1a063a9b-81f0-0310-95a4-ce76da25c4cd

HTML block: Disable viewport visibility support

571aa04

sagarjadhav requested review from ajitbohra, fabiankaegy and juanmaguitar as code owners March 4, 2026 11:30

github-actions bot added the [Package] Block library /packages/block-library label Mar 4, 2026

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 4, 2026

sagarjadhav mentioned this pull request Mar 4, 2026

Responsive visibility does not work for blocks without a wrapper tag, such as custom HTML blocks. #76128

Closed

6 tasks

Mamaduka added [Type] Bug An existing feature does not function as intended [Block] HTML Affects the the HTML Block labels Mar 4, 2026

Mamaduka requested changes Mar 4, 2026

View reviewed changes

Shortcode block: Disable viewport visibility support

864fa7d

t-hamano added the [Block] Shortcode Affects the Shortcode Block label Mar 4, 2026

Mamaduka changed the title ~~HTML block: Disable viewport visibility support~~ HTML & Shortcode: Disable viewport visibility support Mar 4, 2026

Mamaduka approved these changes Mar 4, 2026

View reviewed changes

Mamaduka added the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 4, 2026

Mamaduka merged commit d0a49cd into WordPress:trunk Mar 4, 2026
46 checks passed

github-actions bot added this to the Gutenberg 22.8 milestone Mar 4, 2026

github-actions bot removed the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 4, 2026

github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTML & Shortcode: Disable viewport visibility support#76138

HTML & Shortcode: Disable viewport visibility support#76138
Mamaduka merged 2 commits intoWordPress:trunkfrom
sagarjadhav:fix/html-disable-viewport-visibility

sagarjadhav commented Mar 4, 2026 •

edited by Mamaduka

Loading

Uh oh!

github-actions bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

Mamaduka left a comment

Uh oh!

shimotmk commented Mar 4, 2026

Uh oh!

Mamaduka commented Mar 4, 2026

Uh oh!

sagarjadhav commented Mar 4, 2026

Uh oh!

t-hamano commented Mar 4, 2026

Uh oh!

t-hamano commented Mar 4, 2026

Uh oh!

Mamaduka left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

ramonjd commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sagarjadhav commented Mar 4, 2026 • edited by Mamaduka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before

After

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

Mamaduka left a comment

Choose a reason for hiding this comment

Uh oh!

shimotmk commented Mar 4, 2026

Uh oh!

Mamaduka commented Mar 4, 2026

Uh oh!

sagarjadhav commented Mar 4, 2026

Uh oh!

t-hamano commented Mar 4, 2026

Uh oh!

t-hamano commented Mar 4, 2026

Uh oh!

Mamaduka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

ramonjd commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sagarjadhav commented Mar 4, 2026 •

edited by Mamaduka

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading