Size Change: +3.78 kB (+0.06%)

Total Size: 6.88 MB

_{compressed-size-action}

I think feedback from @jasmussen is still applicable - ##76050 (comment). Especially the part regarding naming.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: mtias <matveb@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org>
Co-authored-by: poligilad-auto <poligilad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Didn't want to assume with this different placement but I agree! I'm not sure what the appetite is for making it broader into "Site Identity" and adding in site title and site tagline. I'm game to add them here though if we want to go in that direction.

We don't have to add new controls in this PR, but standartizing identity panel here would be nice. @mtias, what do you think?

Nice! I'm still a fan. I still think the contents of the second panel could benefit from some rephrasings, and I personally still think we should call it just "Identity", so it fits neatly in context of other single-word menu items (Navigation, Templates, Patterns, Styles).

But even if we don't go with "Identity", it should be sentence case with capital proper nouns. Which means "Site identity", or "Site Logo & icon" (the latter which is clumsy).

Didn't want to assume with this different placement but I agree! I'm not sure what the appetite is for making it broader into "Site Identity" and adding in site title and site tagline. I'm game to add them here though if we want to go in that direction.

This is something it can grow into, but I would still start simple, one small patch and then go from there.

To update the suggestions for the contents of the panel, with the other feedback left on the previous thread:

< Identity

Your site logo and icon help visitors recognize your brand across the web. The logo appears 
in your site's layout wherever the Site Logo block is placed. The icon shows in browser tabs, bookmarks, and mobile app shortcuts.

SITE LOGO
[ Choose logo ]
Displays in your site's layout via the Site Logo block.

SITE ICON
[ Choose icon ]
Shown in browser tabs, bookmarks, and mobile apps. It should be square and at least 512 by 512 pixels.

Whether compact or not, it seems like it should be either both are big, or both are compact, to be egalitarian to their respective value. The argument for big is: there's room, and no reason not to use the space.

I love this, but it's also a bit of a slippery slope to me. With this addition we are starting to move things from previous "Settings -> General" into a new non extendable top level menu item within the site editor.

The concept of "Site Identity" that has been mentioned here a few times already feels like it's keeping the door a little more open for further sub settings. But I think ideally this warrants a larger big picture plan for how we want to handle all kinds of site settings in the future.

I prefer this a lot more to the version that had it on Styles (which is wrong, since the icon/logo do not vary with theme.json variations).

@fabiankaegy I could see something like:

• Top level "Settings" drilldown
• Submenu items mirroring something like what we have in wp-admin to begin with
• "Site Identity" section, either in "General" or standalone view

The idea being that all settings are consolidated in a single location, kind of like the Settings app on iOS. That said, introducing a drilldown solely for Site Identity would be a bit excessive at this stage.

I do think we ought to consider naming this new view "Site Identity" though, and including controls for the site title and tagline.

Thanks for all the feedback. This is fun and exciting to work on 😄. To keep this PR shippable and small, I've done the following:

• Changed the title to Identity. I like that this keeps it relevant to the current settings and better matches the other items.
• Updated the text to match what @jasmussen shared here
  
• Addressed the technical feedback given as best as I can.

I purposefully have not added in site title or tagline but we can consider that in the future based on feedback. Rather than a video, here's a quick screenshot:

My final questions are:

• Do we like the order of the items? I honestly made this decision based on feel and what I know from user feedback and testing.
• What should we put in the save flow?
• Any more thoughts around having the images expanded rather than compact? I still prefer compact right now.

Nice work.

Do we like the order of the items? I honestly made this decision based on feel and what I know from user feedback and testing.

Seems fine to me. The precedence is the Site Logo block where Site Icon is secondary.

What should we put in the save flow?

With Site Logo still as precedence, I'd assume we'd do the same here:

To get the above, add a new site logo, and check the box to also update the site icon.

Any more thoughts around having the images expanded rather than compact? I still prefer compact right now.

This is one of those things where it feels valid to just make a call and start there. If it's truly problematic, it will resurface and we can make a small atomic patch to change it.

I purposefully have not added in site title or tagline but we can consider that in the future based on feedback. Rather than a video, here's a quick screenshot:

I wonder if we can also keep only the first sentence in the top description? The rest of it duplicates the help messages below the upload buttons.

I wonder if we can also keep only the first sentence in the top description? The rest of it duplicates the help messages below the upload buttons.

We could potentially go a step further and remove the description entirely. A UI only containing two form fields with well crafted labels and help text arguably shouldn't need a description.

I purposefully have not added in site title or tagline but we can consider that in the future based on feedback.

I also find it confusing that site logo and site icon are separate from site title and tagline. All four directly affect the frontend and visually appear together, based on the site's configuration, so it makes sense to group them. Ideally, we bring site title and tagline over now, or at least plan to in a future iteration.

Flaky tests detected in a76d816.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22756502509
📝 Reported issues:

• [Flaky Test] Custom Completer: should allow newlines after multiple option completions #48535 in /test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js
• [Flaky Test] User Mention: should allow mention selection via keypress event #48416 in /test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js
• [Flaky Test] should undo bold #48558 in /test/e2e/specs/editor/various/undo.spec.js

Thank you all again for the feedback and @ntsekouras for helping simplify the code. I just pushed another update:

• Renamed files, components, and route from site-logo-and-icon to identity to match the section name.
• Reverted out-of-scope changes to site-logo block's edit.js.
• Removed Identity section description due to feedback around how it feels too wordy/duplicates what's already there.
• Ensured site logo is listed before site icon in save panel.

Here's where we are now, visually:

Anything else or shall we land this thing? 🚀

Looks good to me. It mostly needs a code check.

Thank you all for the help here. I merged and will create a follow up issue (and likely PR) to consider adding site title and tagline next.

Late to the party, but this looks great!

One thing I noticed , I see a bit of a disconnect in how we're handling media selection here vs other places. This uses a dotted border with an X button that says "Remove," while other media selectors (like background) use a different layout with "Reset" and the reset icon (same way as we do it with colors).

Might be worth unifying the design language for these fields at some point, unless I'm missing something about why they should be different?