Extract inserter-toggle mixin from duplicated button styles#76087
Merged
Extract inserter-toggle mixin from duplicated button styles#76087
Conversation
The dark inserter toggle button styles (background, color, size, hover state) were duplicated across three SCSS files. Extract them into a shared inserter-toggle mixin in base-styles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Block editor
|
Size Change: +17 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b7bb72. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22628170833
|
mikachan
approved these changes
Mar 3, 2026
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
Nice refactor! Code changes look good, and it's testing as described. LGTM 🚢
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
…s#76087) * Extract inserter-toggle mixin from duplicated button styles The dark inserter toggle button styles (background, color, size, hover state) were duplicated across three SCSS files. Extract them into a shared inserter-toggle mixin in base-styles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * add comment --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracts the dark inserter toggle button styles into a shared
inserter-togglemixin inpackages/base-styles/_mixins.scss.Why?
The same button appearance rules (dark background, white icon, 24px size, theme-color hover) were duplicated across three SCSS files:
default-block-appender/content.scss(2 occurrences)block-tools/style.scss(1 occurrence)This duplication makes it easy for the styles to drift apart and harder to maintain. A shared mixin ensures consistency. This will also make it easier to have consistent styles in #75674
How?
@mixin inserter-toggle()topackages/base-styles/_mixins.scsscontaining the common rules:background,color,padding,min-width,height, and:hoverstate.content.scssandstyle.scsswith@include inserter-toggle, keeping any site-specific overrides (e.g.display: none,flex-direction,width).@useimport for mixins incontent.scss(already present instyle.scss).Testing Instructions