Skip to content

Interactivity API: Fix router initialization race condition on Safari/Firefox #76053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luisherranz merged 26 commits into from
Mar 5, 2026
Merged

Interactivity API: Fix router initialization race condition on Safari/Firefox #76053

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
52d68bc
Introduce synchronization promise for initialVdom to resolve race con…
Mar 2, 2026
9d7b387
Update hydration.ts
Mar 2, 2026
61ab3f4
Expose initialVdomPromise via privateApis
Mar 2, 2026
3030539
Fix router race condition by awaiting hydration
Mar 2, 2026
0208546
Fixed the TypeScript error (`TS18004`)
Mar 2, 2026
e6ca1d1
Fix Prettier formatting in hydration.ts
Mar 2, 2026
00dbd54
Fix Prettier formatting for resolveInitialVdom type
Mar 2, 2026
e500ae2
Add test block registration for router hydration race condition
Mar 3, 2026
8b9371a
Interactive markup for router race condition test block
Mar 3, 2026
74f658e
Force static router import to make hydration race deterministic in al…
Mar 3, 2026
4214b0d
Add store with context and state actions for router race condition test
Mar 3, 2026
08dba8c
Add e2e test for router hydration race condition
Mar 3, 2026
cbea0bd
Add PHP docblock to render.php to satisfy PHPCS coding standards
Mar 3, 2026
9d04f95
Fix TypeScript errors in spec: use requestUtils.createPage instead of…
Mar 3, 2026
ca764be
Fix e2e spec: use interactivityUtils fixture to activate test plugin
Mar 3, 2026
e651478
Evaluate router code
DAreRodz Mar 4, 2026
236c303
Make interactive region a router region
DAreRodz Mar 4, 2026
f55e9e0
Run e2e tests in Safari and Firefox too
DAreRodz Mar 4, 2026
b1b07f1
Move goto to a beforeEach callback and simplify comments
DAreRodz Mar 4, 2026
b5226c1
Update CHANGELOG.md
Mar 4, 2026
1e1601e
Update CHANGELOG iAPI
Mar 4, 2026
33fdef5
Update CHANGELOG.md
Mar 4, 2026
aaf7637
Update CHANGELOG.md (iAPI-router)
Mar 4, 2026
997f334
Interactivity: Remove initialVdom from privateApis exports
Mar 4, 2026
c1fed18
Interactivity Router: Remove initialVdom import, use WeakMap type in …
Mar 4, 2026
e5e37bd
Merge branch 'trunk' into Router-initialization-race-condition-on-Saf…
Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Interactivity: Remove initialVdom from privateApis exports
  • Loading branch information
Marcus Karlos
Marcus Karlos authored Mar 4, 2026
commit 997f334bbe5301c9e95cae98824553473fd055fd
2 changes: 0 additions & 2 deletions packages/interactivity/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { batch, effect } from '@preact/signals';
*/
import registerDirectives, { routerRegions } from './directives';
import {
initialVdom,
initialVdomPromise,
hydrateRegions,
getRegionRootFragment,
Expand Down Expand Up @@ -79,7 +78,6 @@ export const privateApis = (
if ( lock === requiredConsent ) {
return {
getRegionRootFragment,
initialVdom,
initialVdomPromise,
toVdom,
directive,
Expand Down