Repository navigation
Editor: Decode HTML entities in raw post title input - #76022
Open
Mustafabharmal wants to merge 1 commit into
Open
Mustafabharmal wants to merge 1 commit into
Mustafabharmal wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @anrghg. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #44445
Applies
decodeEntities()to the title value displayed in the raw (code editor) post title input field.Why?
When a post title contains HTML entities (e.g.,
&,<,&), the raw post title editor (PostTitleRaw) displays them literally instead of their decoded characters. For example, a title stored asTom & Jerryshows asTom & Jerryinstead ofTom & Jerry.The visual editor already handles this correctly because
useRichTextinternally parses the value viaRichTextData.fromHTMLString(), which decodes entities. The raw editor, however, passes the title string directly to<TextareaControl>.How?
Wrapped the
titlevalue withdecodeEntities()in thePostTitleRawcomponent before passing it to<TextareaControl>. ThedecodeEntitiesimport was already present in the file (used for the placeholder).Testing Instructions
Tom & JerryorA < B)Screenshots or screencast