Make inspector style transform previews consistent with toolbar transforms#75989
Merged
tellthemachines merged 2 commits intotrunkfrom Mar 2, 2026
Merged
Make inspector style transform previews consistent with toolbar transforms#75989tellthemachines merged 2 commits intotrunkfrom
tellthemachines merged 2 commits intotrunkfrom
Conversation
tellthemachines
requested review from
andrewserong,
fcoveram,
ramonjd and
talldan
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
added
[Type] Enhancement
|
Size Change: -248 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee9618a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22471671153
|
ramonjd
approved these changes
Feb 27, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
| Before | After |
|---|---|
 |
 |
Tooltip remains!
Can't find any regressions - mouseovers work as expected, keyboard focus too 👍🏻
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import BlockStylesPreviewPanel from './preview-panel'; |
Member
There was a problem hiding this comment.
I think this file is now no longer used and can be deleted, possibly the accompanying styles in .block-editor-block-styles__preview-panel
Contributor
Author
There was a problem hiding this comment.
Yeah this should be safe to delete because it's not exported outside of the block styles component, well spotted!
Comment on lines
+45
to
+63
| const previewBlocks = useMemo( () => { | ||
| if ( ! hoveredStyle || ! genericPreviewBlock ) { | ||
| return null; | ||
| } | ||
| const previewClassName = replaceActiveStyle( | ||
| className, | ||
| activeStyle, | ||
| hoveredStyle | ||
| ); | ||
| return [ | ||
| { | ||
| ...genericPreviewBlock, | ||
| attributes: { | ||
| ...( genericPreviewBlock.attributes || {} ), | ||
| className: previewClassName, | ||
| }, | ||
| }, | ||
| ]; | ||
| }, [ hoveredStyle, genericPreviewBlock, className, activeStyle ] ); |
Member
There was a problem hiding this comment.
Non-blocking comment. https://github.com/WordPress/gutenberg/blob/try/consistent-transform-previews/packages/block-editor/src/components/block-switcher/block-styles-menu.js#L29-L47 has the same code block.
Could be a candidate for extraction into a small hook
Contributor
Author
There was a problem hiding this comment.
Yeah I wondered whether it would be worth a hook or a wrapper for PreviewBlockPopover and ended up not doing so because I couldn't decide on the best approach 😄
my go-to strategy is usually extract once there are more than 2 instances, so I just left it alone
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
…forms (#75989) Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up from this comment.
The style transforms in the block inspector were using
BlockStylesPreviewPanelcreated for the block inserter, that by default renders the name of the block (or variation in this case):We don't really need that for style switching, and @fcoveram suggested removing it and also removing the "preview" title from the
PreviewBlockPopoverthat the toolbar block transforms use.This PR removes the "preview" title from
PreviewBlockPopoverand adds a couple props to it so it can be reused in the inspector, instead ofBlockStylesPreviewPanel.Testing Instructions