Skip to content

Navigation overlay: Prevent duplicate area registration#75906

Merged
t-hamano merged 3 commits intotrunkfrom
fix-navigation-overlay-duplicate-area
Feb 25, 2026
Merged

Navigation overlay: Prevent duplicate area registration#75906
t-hamano merged 3 commits intotrunkfrom
fix-navigation-overlay-duplicate-area

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented Feb 25, 2026

Follow-up on #74968

What?

Before After
image image

Why?

If a navigation overlay area has already been registered with the core, we should not register the same area again.

Testing Instructions

Open the Add Template modal and check the areas.

@t-hamano t-hamano self-assigned this Feb 25, 2026
@t-hamano t-hamano added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Feature] Navigation Overlays [Type] Bug An existing feature does not function as intended labels Feb 25, 2026
@t-hamano t-hamano marked this pull request as ready for review February 25, 2026 12:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Feb 25, 2026
Copy link
Copy Markdown
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot thanks for fixing!

t-hamano and others added 2 commits February 25, 2026 21:26
Co-authored-by: Dave Smith <getdavemail@gmail.com>
@t-hamano t-hamano merged commit 0f020b0 into trunk Feb 25, 2026
41 of 42 checks passed
@t-hamano t-hamano deleted the fix-navigation-overlay-duplicate-area branch February 25, 2026 13:45
@github-actions github-actions bot added this to the Gutenberg 22.7 milestone Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Navigation Overlays Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants