Address remaining review feedback from WebAssembly support detection#75847
Closed
im3dabasia wants to merge 5 commits intoWordPress:trunkfrom
Closed
Address remaining review feedback from WebAssembly support detection#75847im3dabasia wants to merge 5 commits intoWordPress:trunkfrom
im3dabasia wants to merge 5 commits intoWordPress:trunkfrom
Conversation
im3dabasia
added
[Feature] Client Side Media
Contributor
Author
|
Hi @adamsilverstein, Currently I see that there was an issue (#74822) related to testing the client side media experiment here in the attached issue. I went over to this PR as well (#74566). I am not getting the option under experiments to enable the Client Side Media experiment. My environment:
Could you please help me and let me know what I am missing here? TIA |
Contributor
Author
|
Closing this PR as per this comment #75605 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR - WIP
What?
Part of: #75605
This PR addresses the remaining feedback items mentioned in #75605, which were originally part of #74827.
Why?
To resolve the unaddressed review comments from the WebAssembly support detection PR and clean up related implementation details.
How?
This PR includes the following updates:
✅ Removed the WebAssembly support check (as discussed in review).
✅ Stopped exporting clearFeatureDetectionCache (kept internal to tests).
✅ Moved shouldEnableClientSideMediaProcessing to the upload-media package for better reusability.
✅ Fixed inconsistent trailing periods in reason strings.
ℹ️ The redundant cross-origin isolation check had already been removed previously.
Testing Instructions
I would appreciate help validating the testing approach for this change. If someone can share any reference steps or guidance on how best to test the WebAssembly detection and fallback paths, that would be very helpful.