iAPI Docs: Introduce reactive vs non-reactive distinction early in the state/context guide#75357
Conversation
luisherranz
requested review from
fabiankaegy and
juanmaguitar
as code owners
luisherranz
added
the
[Feature] Interactivity API
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Copilot. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
With this addition, maybe we should rename the doc page to: "Understanding global state, local context, derived state and config" |
|
Sure. @copilot can you do it? (I have no idea if this is possible 😄) |
|
@luisherranz I've opened a new pull request, #75473, to work on those changes. Once the pull request is ready, I'll request review from you. |
Done by copilot in d0e43a1 |
|
@copilot merge trunk and resolve conflicts. |
|
@luisherranz I've opened a new pull request, #75477, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot can you merge this other PR into this one, make sure everything in that PR is covered here? It seems like a PR that should be unnecessary if we merge this one, but I want to make sure we're not forgetting anything. |
|
@luisherranz I've opened a new pull request, #75512, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot try to merge trunk and resolve the conflicts again. |
|
@luisherranz I've opened a new pull request, #75514, to work on those changes. Once the pull request is ready, I'll request review from you. |
It seems that Copilot is not able to do it, we'll have to do it manually. |
DAreRodz
force-pushed
the
iapi-docs-introduce-config-early
branch
from
1b1b1ee to
726a311
Compare
DAreRodz
left a comment
DAreRodz
left a comment
There was a problem hiding this comment.
LGTM!
@juanmaguitar, I guess this would require a redirection in the Block Editor Handbook like the one you mentioned in #74974 (comment), right?
|
Flaky tests detected in 726a311. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22077821594
|
|
@DAreRodz, thanks for fixing the conflicts. @juanmaguitar, feel free to merge the PR once you think everything is ready! |
…e state/context guide
…75473) * Initial plan * Rename doc file to include config and fix typo Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>
…5512) * Initial plan * Update manifest.json and toc.json to fix typo and include config Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>
DAreRodz
force-pushed
the
iapi-docs-introduce-config-early
branch
from
726a311 to
2723578
Compare
What?
Follow up to #71355
Introduce the distinction between reactive and non-reactive data at the beginning of the Interactivity API state/context guide.
Why?
As @DAreRodz pointed out in the review of #71355, the term "config" is not introduced until the very end of the document. Adding a reactive vs non-reactive distinction at the beginning helps readers understand the full picture before diving into details.
How?