Navigation: Add a shared helper for font sizes in Navigation Link and Navigation Submenu blocks by scruffian · Pull Request #74855 · WordPress/gutenberg

scruffian · 2026-01-22T13:10:22Z

What?

Consolidate the font size calculation function for navigation link and navigation submenu blocks to a shared helper.

Why?

Reducing duplicate code avoids bugs and makes maintenance easier.

How?

Moved the duplicate build_css_font_sizes functions from navigation-link and navigation-submenu to a new shared file: packages/block-library/src/navigation-link/shared/build-css-font-sizes.php

Testing Instructions

Add a Navigation block to a post/page
Add some Navigation Link and Navigation Submenu blocks within it
In the block settings sidebar, set a custom font size for the navigation block
(this applies via context to child blocks)
Save and view on the frontend
Verify that both navigation links and submenus display with the correct font size
Test with both named font sizes (e.g., "Medium") and custom pixel values

scruffian · 2026-02-17T10:07:37Z

@copilot can you rebase this?

Copilot · 2026-02-17T10:07:45Z

@scruffian I've opened a new pull request, #75609, to work on those changes. Once the pull request is ready, I'll request review from you.

scruffian · 2026-02-18T10:48:16Z

@copilot can you open a new PR that consolidates the font size calculation function for navigation link and navigation submenu blocks to a shared helper?

Copilot · 2026-02-18T10:48:24Z

@scruffian I've opened a new pull request, #75672, to work on those changes. Once the pull request is ready, I'll request review from you.

…ubmenu blocks Extract the duplicated `build_css_font_sizes` function from both navigation-link and navigation-submenu into a shared helper file, following the same pattern established for item-should-render and render-submenu-icon shared helpers. Uses the IS_GUTENBERG_PLUGIN guard at call sites so the correct (prefixed vs unprefixed) function name is used in both the Gutenberg plugin build and WordPress Core. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-03-12T10:23:26Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

jeryj

Both home-link and page-list blocks use the same font sizes function. Let's update those to use this shared function too. Thanks for this refactor! One function instead of four identical ones is much better!

jeryj · 2026-03-19T14:25:19Z

packages/block-library/src/navigation-link/index.php

 		return '';
 	}

-	$font_sizes      = block_core_navigation_link_build_css_font_sizes( $block->context );


Same comment as in #75685 (comment), I prefer leaving this and putting the IS_GUTENBERG_PLUGIN logic within it with comments to help explain it and hide the complexity. This line could stay the same and the complexity goes within block_core_navigation_link_build_css_font_sizes

This won't work because block_core_navigation_link_build_css_font_sizes isn't defined in core yet, so we'll get a fatal error (Uncaught Error: Call to undefined function block_core_shared_get_submenu_visibility()). That solution will only work once the function is backported to core.

Replace the duplicate block_core_page_list_build_css_font_sizes function with the shared block_core_shared_navigation_build_css_font_sizes helper, matching the pattern used by Navigation Link and Submenu blocks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace the duplicate block_core_home_link_build_css_font_sizes function with the shared block_core_shared_navigation_build_css_font_sizes helper. This also fixes Home Link not supporting fluid typography for custom font sizes, aligning it with Navigation Link, Submenu, and Page List blocks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove extra alignment spaces on $colors and $classes assignments that were left over after replacing the single-line $font_sizes assignment with a multi-line IS_GUTENBERG_PLUGIN conditional block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ites The gutenberg_ prefix is needed because Core already defines its own per-block build_css_font_sizes functions, and the shared file cannot redeclare them without causing a fatal error. The else branch calls the unprefixed shared helper which will be available once backported to Core. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

scruffian · 2026-03-19T15:30:52Z

@jeryj thanks for testing. I have made the comments more explicit but I don't think we can do as you suggest above.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

getdave

I tested this and it works with preset and custom sizes.

Noticed some nits.

getdave · 2026-03-28T01:25:01Z

packages/block-library/src/navigation-link/shared/build-css-font-sizes.php

+ * Build an array with CSS classes and inline styles defining the font sizes
+ * which will be applied to the navigation markup in the front-end.
+ *
+ * @since 5.9.0


Does this need updating?

packages/block-library/src/navigation-link/index.php

packages/block-library/src/navigation-submenu/index.php

packages/block-library/src/page-list/index.php

Co-authored-by: Dave Smith <getdavemail@gmail.com>

packages/block-library/src/navigation-link/shared/build-css-font-sizes.php

github-actions · 2026-03-28T02:03:17Z

Flaky tests detected in c68b0d1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23674514733
📝 Reported issues:

[Flaky Test] post title and content are editable and blocks can be inserted #76524 in /test/e2e/specs/editor/various/post-content-focus-mode.spec.js

scruffian requested a review from getdave January 22, 2026 13:10

scruffian self-assigned this Jan 22, 2026

scruffian added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Jan 22, 2026

github-actions bot added the [Package] Block library /packages/block-library label Jan 22, 2026

scruffian changed the title ~~Update/block core shared navigation build css font sizes~~ Navigation: Add a shared helper for font sizes in Navigation Link and Navigation Submenu blocks Jan 22, 2026

Copilot AI mentioned this pull request Feb 17, 2026

Navigation: Unable to rebase PR due to environment restrictions #75609

Closed

Copilot AI mentioned this pull request Feb 18, 2026

Navigation: Consolidate duplicate font size helpers into shared function #75672

Closed

scruffian force-pushed the update/block_core_shared_navigation_build_css_font_sizes branch 2 times, most recently from 042a8ea to b4f1e9b Compare February 18, 2026 17:32

scruffian force-pushed the update/block_core_shared_navigation_build_css_font_sizes branch from 192cb26 to 23e4ea2 Compare March 12, 2026 10:13

scruffian marked this pull request as ready for review March 12, 2026 10:23

scruffian requested review from ajitbohra and fabiankaegy as code owners March 12, 2026 10:23

jeryj reviewed Mar 19, 2026

View reviewed changes

scruffian and others added 5 commits March 19, 2026 14:56

Update IS_GUTENBERG_PLUGIN comments to clarify automatic prefixing

03a60a5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update IS_GUTENBERG_PLUGIN comments to explain build system prefixing

816e6bd

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

getdave approved these changes Mar 28, 2026

View reviewed changes

scruffian and others added 7 commits March 28, 2026 10:33

Update packages/block-library/src/navigation-link/index.php

877ca12

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/navigation-link/index.php

855773f

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/page-list/index.php

4305741

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/page-list/index.php

051b14c

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/page-list/index.php

6e7ef93

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/navigation-submenu/index.php

0daef67

Co-authored-by: Dave Smith <getdavemail@gmail.com>

Update packages/block-library/src/navigation-submenu/index.php

0091929

Co-authored-by: Dave Smith <getdavemail@gmail.com>

scruffian commented Mar 28, 2026

View reviewed changes

packages/block-library/src/navigation-link/shared/build-css-font-sizes.php Outdated Show resolved Hide resolved

Apply suggestion from @scruffian

c68b0d1

scruffian enabled auto-merge (squash) March 28, 2026 01:34

scruffian disabled auto-merge March 28, 2026 02:10

scruffian enabled auto-merge (squash) March 28, 2026 02:10

scruffian merged commit 5f60541 into trunk Mar 28, 2026
39 checks passed

scruffian deleted the update/block_core_shared_navigation_build_css_font_sizes branch March 28, 2026 02:15

github-actions bot added this to the Gutenberg 22.9 milestone Mar 28, 2026

Conversation

scruffian commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Uh oh!

scruffian commented Feb 17, 2026

Uh oh!

Copilot AI commented Feb 17, 2026

Uh oh!

scruffian commented Feb 18, 2026

Uh oh!

Copilot AI commented Feb 18, 2026

Uh oh!

github-actions bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeryj left a comment

Choose a reason for hiding this comment

Uh oh!

jeryj Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

scruffian Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

scruffian commented Mar 19, 2026

Uh oh!

getdave left a comment

Choose a reason for hiding this comment

Uh oh!

getdave Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

scruffian commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Mar 12, 2026 •

edited

Loading