Repository navigation
Conversation
Contributor
Author
|
Closing as not needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a WIP experiment, not ready for review.
This PR adds a new
two-columnslayout option for DataForm components. The layout displays form field labels and descriptions on the left side, with form controls contained in a card on the right side.Why?
The two-columns layout provides a more structured and visually organized way to display form fields, particularly useful for forms with longer labels or descriptions. This layout option gives developers more flexibility in how they present form data to users.
How?
The implementation consists of three main parts:
Type Definitions (
packages/dataviews/src/types/dataform.ts):'two-columns'to theLayoutTypeunion typeTwoColumnsLayoutandNormalizedTwoColumnsLayouttype definitionsLayoutandNormalizedLayoutunion types to include the new layoutComponent Implementation (
packages/dataviews/src/components/dataform-layouts/two-columns/):FormTwoColumnsFieldcomponent that renders fields in a two-column layoutIntegration:
packages/dataviews/src/components/dataform-layouts/index.tsxpackages/dataviews/src/components/dataform-layouts/normalize-form.tsTesting Instructions
DataForm > Layout Two ColumnsstoryTesting Instructions for Keyboard
Screenshots or screencast