Skip to content

@wordpress/ui: use semantic dimension tokens #74557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 6 commits into from
Feb 4, 2026
Merged

@wordpress/ui: use semantic dimension tokens #74557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d808b1
Button: use dimension tokens
ciampo Jan 12, 2026
4128d59
InputLayou: use semantic dimension tokens
ciampo Feb 3, 2026
49caf37
Tabs: use semantic dimension tokens
ciampo Feb 3, 2026
0712c31
CHANGELOG
ciampo Feb 3, 2026
30abf52
Add TODOs for using dimension tokens for height/size
ciampo Feb 4, 2026
f4be6e3
Prevent hardcoded value
ciampo Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .stylelintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ module.exports = {
{
files: [ '**/*.module.css' ],
rules: {
'function-no-unknown': [
true,
{
ignoreFunctions: [
// CSS stepped value math functions in Baseline 2024.
// This rule exception can likely be removed when
// updating to a more recent version of Stylelint.
'round',
'rem',
'mod',
],
},
],
'declaration-property-max-values': {
// Prevents left/right values with shorthand property names (unclear for RTL)
margin: 3,
Expand Down
4 changes: 4 additions & 0 deletions packages/ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@

- `Button`: Add minimum content width (`6ch` + padding) to prevent overly narrow buttons with short labels ([#75133](https://github.com/WordPress/gutenberg/pull/75133)).

### Internal

- `Button`, `InputLayout`, `Tabs`: use semantic dimension tokens ([#74557](https://github.com/WordPress/gutenberg/pull/74557)).

## 0.6.0 (2026-01-29)

### New Features
Expand Down
6 changes: 3 additions & 3 deletions packages/ui/src/button/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
--wp-ui-button-foreground-color: var(--wpds-color-fg-interactive-brand-strong);
--wp-ui-button-foreground-color-active: var(--wpds-color-fg-interactive-brand-strong-active);
--wp-ui-button-foreground-color-disabled: var(--wpds-color-fg-interactive-neutral-strong-disabled);
--wp-ui-button-padding-inline: calc(3 * var(--wpds-dimension-base)); /* TODO: Create new interactive padding tokens */
--wp-ui-button-padding-inline: var(--wpds-dimension-padding-md);
--wp-ui-button-height: 40px;
--wp-ui-button-aspect-ratio: auto; /* Useful for overrides such as icon buttons */
--wp-ui-button-font-size: var(--wpds-font-size-md);
Expand All @@ -33,7 +33,7 @@
display: inline-flex;
justify-content: center;
align-items: center;
gap: calc(2 * var(--wpds-dimension-base)); /* TODO: Consider new interactive/control gap tokens */
gap: var(--wpds-dimension-gap-sm);
aspect-ratio: var(--wp-ui-button-aspect-ratio);
min-width: var(--wp-ui-button-min-width);
height: var(--wp-ui-button-height);
Expand Down Expand Up @@ -121,7 +121,7 @@
}

.is-small {
--wp-ui-button-padding-inline: calc(2 * var(--wpds-dimension-base)); /* TODO: Create new interactive padding tokens */
--wp-ui-button-padding-inline: var(--wpds-dimension-padding-sm);
--wp-ui-button-height: 24px;
}

Expand Down
13 changes: 5 additions & 8 deletions packages/ui/src/form/primitives/input-layout/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

@layer wp-ui-components {
.input-layout {
/* TODO: Use padding tokens */
--wp-ui-input-layout-padding-inline: calc(var(--wpds-dimension-base) * 3);
--wp-ui-input-layout-padding-inline: var(--wpds-dimension-padding-md);

display: flex;
height: 40px;
Expand All @@ -22,14 +21,12 @@
}

&.is-size-compact {
/* TODO: Use padding tokens */
--wp-ui-input-layout-padding-inline: calc(var(--wpds-dimension-base) * 2);
--wp-ui-input-layout-padding-inline: var(--wpds-dimension-padding-sm);
height: 32px;
}

&.is-size-small {
/* TODO: Use padding tokens */
--wp-ui-input-layout-padding-inline: calc(var(--wpds-dimension-base) * 2);
--wp-ui-input-layout-padding-inline: var(--wpds-dimension-padding-sm);
height: 24px;
}

Expand Down Expand Up @@ -66,10 +63,10 @@
&.is-padding-minimal {
--wp-ui-input-layout-prefix-padding-start:
calc(var(--wp-ui-input-layout-padding-inline) -
var(--wpds-dimension-base));
var(--wpds-dimension-padding-xs));
--wp-ui-input-layout-suffix-padding-end:
calc(var(--wp-ui-input-layout-padding-inline) -
var(--wpds-dimension-base));
var(--wpds-dimension-padding-xs));
}

&.is-prefix {
Expand Down
21 changes: 10 additions & 11 deletions packages/ui/src/tabs/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@
}

[data-orientation="horizontal"] & {
padding-inline: calc(4 * var(--wpds-dimension-base)); /* TODO: Use or create new control/interactive padding token */
height: calc(12 * var(--wpds-dimension-base)); /* TODO: Can we eliminate or hard-code? */
padding-inline: var(--wpds-dimension-padding-lg);
height: 48px; /* TODO: use semantic size/height tokens when available */
scroll-margin: 24px;

&::after {
content: "";
inset: calc(3 * var(--wpds-dimension-base)); /* TODO: Use or create new control/interactive padding token */
inset: var(--wpds-dimension-padding-md);
}
}

Expand All @@ -185,18 +185,17 @@

&::after {
/*
* Add enough inset to prevent the focus ring (which is 1.5px thick)
* from being visually clipped by the tablist.
* Prevent clipping the focus ring at the tablist edge.
* Use rounding, as the focus ring width may have sub-pixel values
* depending on the screen pixel ratio.
*/
inset-inline: 2px;
inset-inline: round(up, var(--wpds-border-width-focus), 1px);
}
}

[data-orientation="vertical"] & {
padding:
calc(2 * var(--wpds-dimension-base))
calc(3 * var(--wpds-dimension-base)); /* TODO: Use or create new control/interactive padding token */
min-height: calc(10 * var(--wpds-dimension-base)); /* TODO: Can we eliminate or hard-code? */
padding: var(--wpds-dimension-padding-sm) var(--wpds-dimension-padding-md);
min-height: 40px; /* TODO: use semantic size/height tokens when available */
}

[data-orientation="vertical"][data-select-on-move="false"] &::after {
Expand All @@ -222,7 +221,7 @@

.tab-chevron {
flex-shrink: 0;
margin-inline-end: calc(var(--wpds-dimension-base) * -1); /* TODO: Use or create new control/interactive padding token */
margin-inline-end: calc(var(--wpds-dimension-gap-xs) * -1);

[data-orientation="horizontal"] & {
display: none;
Expand Down
Loading