Skip to content

Fix the dataviews experiment locked fields position on toggle. #74326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 6 commits into from
Jan 12, 2026
Merged

Fix the dataviews experiment locked fields position on toggle. #74326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
538c8dd
Fix the dataviews experiment locked fields position on toggle.
rutviksavsani Jan 1, 2026
a91b08c
add changelog entry and remove a un-necessary check.
rutviksavsani Jan 5, 2026
3b78998
remove the extra check.
rutviksavsani Jan 5, 2026
99f3000
Fix the un-necessary field check.
rutviksavsani Jan 8, 2026
c5fd76c
Update changelog and remove const's that seem extra.
rutviksavsani Jan 11, 2026
30812c9
Merge branch 'WordPress:trunk' into fix/issue-74153-dataviews
rutviksavsani Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add changelog entry and remove a un-necessary check.
  • Loading branch information
@rutviksavsani
rutviksavsani committed Jan 5, 2026
commit a91b08c276602a6fedbb71ba007d0e27d3f3d1ea
1 change: 1 addition & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- DataViews: Combined field alignment in table layout. [#73908](https://github.com/WordPress/gutenberg/pull/73908)
- DataViews: Fix table row multiselection in Firefox [#73945](https://github.com/WordPress/gutenberg/pull/73945)
- DataViews: `filterSortAndPaginate()` will ignore sorting on non-sortable fields [#73950](https://github.com/WordPress/gutenberg/pull/73950)
- DataViews: Fix locked fields order when toggling visibility in properties section. [#74326](https://github.com/WordPress/gutenberg/pull/74326)
Comment thread
rutviksavsani marked this conversation as resolved.
Outdated

### Enhancements

Expand Down
4 changes: 2 additions & 2 deletions packages/dataviews/src/components/dataviews-view-config/properties-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ export function PropertiesSection( {
).length;

const visibleLockedFields = lockedFields.filter(
( { field, isVisibleFlag } ) =>
( { isVisibleFlag } ) =>
// @ts-expect-error
isDefined( field ) && ( view[ isVisibleFlag ] ?? true )
view[ isVisibleFlag ] ?? true
) as Array< {
field: NormalizedField< any >;
isVisibleFlag: string;
Expand Down
Loading