Add Cover to Embed block transform for embedded video backgrounds#74244
Open
Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Open
Add Cover to Embed block transform for embedded video backgrounds#74244Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Mayank-Tripathi32 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Mayank-Tripathi32
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#74210
What?
Adds support for transforming Cover blocks with embedded video backgrounds (YouTube, Vimeo, etc.) to the appropriate Embed block.
Why?
Follow-up to #73023 which added embedded video background support to Cover blocks. Currently, editors cannot easily convert a Cover block with an embedded video back to a standalone Embed block, limiting content portability and requiring manual recreation.
How?
EMBED_VIDEO_BACKGROUND_TYPEcreateUpgradedEmbedBlockutility to create the correct embed variation (YouTube, Vimeo, etc.)Testing Instructions
https://www.youtube.com/watch?v=dQw4w9WgXcQ)Screenshots
https://q7utzrengv.ufs.sh/f/Wgl9eBAmTj29gpWbqRxbvUVCLRtOZBc09F7pY3E1zdm6eXIS