Closed
Conversation
|
Size Change: +1.09 kB (+0.04%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cefbe0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19508159715
|
jeryj
reviewed
Nov 19, 2025
Comment on lines
+162
to
+167
| if ( getBlockName( selectedBlockClientId ) === 'core/navigation' ) { | ||
| // If the selected block is navigation, exclude all its descendants | ||
| descendants.forEach( ( childId ) => | ||
| navigationChildren.add( childId ) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
This makes it so if your only item within the pattern is a navigation block, nothing shows in your inspector sidebar. I don't think this code is necessary. What was it for?
scruffian
force-pushed
the
add/navigation-content-only-prototype
branch
from
16c5aa4 to
54bc434
Compare
scruffian
commented
Nov 20, 2025
| @@ -0,0 +1,201 @@ | |||
| /** | |||
Contributor
Author
There was a problem hiding this comment.
This whole file is copy/pasted
Contributor
Author
|
This has served its purpose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast