-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Bindings: Fix core/term-data source bug, refactor, add unit test coverage
#73366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Block Bindings: Fix core/term-data source bug, refactor, add unit test coverage
#73366
Conversation
core/term-data source
|
Size Change: -122 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
89de7e1 to
873a32c
Compare
615cec9 to
d85280a
Compare
core/term-data sourcecore/term-data source, add unit test coverage
|
I'm missing some clarity about the shape of |
7e6eae8 to
163552c
Compare
…a isn't provided by context
163552c to
dbba6bf
Compare
core/term-data source, add unit test coveragecore/term-data source bug, refactor, add unit test coverage
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over the changes and it seems like a lot of code is moving around, but there aren't a lot of significant changes beyond creating a stable object. If there are any specific changes you'd like review on, please highlight them.
I don't see anything concerning and this tests well for me.
What?
Refactor
core/post-datablock bindings source, and add unit test coverage. Modeled after #72739 and #73055.This fixes a bug that was discovered by @jeryj, see #73406. For more information, see testing instructions below.
Why?
First of all, to fix a bug (see testing instructions below).
Additionally, or cleaner separation of listing available fields vs. fetching field values.
Furthermore, we should set a good example in the code of these sources since people will refer to these files when implementing their own sources.
We also didn't have any test coverage for that source yet.
For reference, #72799 added unit tests for the
core/post-metasource, and #73055 for thecore/post-datasource.Testing Instructions
Reproduce the following bug in
trunk:Now switch to this PR's branch, and verify that the issue is fixed.
Additionally, perform some smoke testing. The
core/term-datasource is mostly used for Navigation links to taxonomy term pages, so: