Repository navigation
Theme: Update precomputed color ramps script for Node.js v20.10 compatibility - #72971
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the script added in #72847 to ensure compatibility with Node.js v20.10.0, which is the current minimum version supported and current version of Node.js used on WordPress build servers.
Follow-up to #72847
Related Slack discussion: https://wordpress.slack.com/archives/C02QB2JS7/p1762245589360919
Why?
So that developers running versions of Node.js which are claimed to be supported don't encounter errors when running these scripts.
How?
Replaces
import.meta.dirnamewith an equivalent implementation that is compatible with Node.js v20.10.0.import.meta.dirnamewas added in Node.js v20.11.0.Testing Instructions
Verify the script runs successfully on Node.js v20.10.0 and produces no errors: