-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Testing: Test across OS and Node.js version for commits to trunk #72946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.45 MB ℹ️ View Unchanged
|
|
I'm running into a few other Windows issues unrelated to the one I was originally trying to address here, so I'll have to spend some time working through those. Slack discussion ongoing: https://wordpress.slack.com/archives/C02RQBWTW/p1762200484307419 |
|
Flaky tests detected in 48eb31e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19074321393
|
Consistent with expectations for tooling, e.g. editorconfig
8025e7f to
967e001
Compare
This reverts commit efc4207.
|
Okay, this seems to be working now! I think the issues I was seeing yesterday were real Windows issues fixed separately by @t-hamano in #72960. There also seemed to be some Windows incompatibility in The Windows & default static analysis checks are now passing (see Windows run log):
With the demonstration configuration reverted in 48eb31e, this should be ready for review now. |
Personally, I feel like it'd probably be good to have at least one Windows build run as a required check in pull requests, so that we don't have to wait 'til it lands in |
To be honest, I feel a php version (maybe the oldest supported php version) would actually be more important to run than windows. But it's very hard to decide, let's keep statusquo and monitor what failures we see on trunk more. |

What?
Updates the "Static Checks" GitHub Actions workflow to run across multiple versions of Node.js and multiple operating systems for commits to trunk.
Why?
Lately there's been a few incidents where non-Windows-compatible code has been merged to
trunk, and only later discovered to be incompatible whenwordpress-developbuilds start to fail.Examples:
Additionally, testing across different versions of Node.js ensures that we're better prepared for future updates.
Related: #71091
How?
Adds a matrix configuration similar to what we have for other builds, ensuring a combination of testing across:
OS:
macos-15ubuntu-14.04windows-2025Node.js versions:
202224Consistent with #72506, these workflows only run on
trunkfor any combination of the above other thanubuntu-14.04+20. This should at least provide a faster feedback loop than currently waiting for builds to fail inwordpress-develop.Testing Instructions
A demonstration commit causing Windows to be included in the strategy should hopefully show an expected failure.