Skip to content

Conversation

@jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Nov 3, 2025

This PR should fix failing CI checks in trunk, caused by three interacting PRs:

@jsnajdr jsnajdr self-assigned this Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jsnajdr jsnajdr added the [Type] Build Tooling Issues or PRs related to build tooling label Nov 3, 2025
@jsnajdr jsnajdr requested a review from mirka November 3, 2025 09:43
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was about to look into this 😄

@jsnajdr
Copy link
Member Author

jsnajdr commented Nov 3, 2025

There's a problem with the performance tests check failing because it fails to build the trunk version:

Error: packages/boot/tsconfig.json(20,3): error TS6306: Referenced project '/tmp/wp-performance-tests/environments/trunk/plugin/packages/theme' must have setting "composite": true.

That's exactly the error we're fixing in this PR. How can we merge this despite the CI check failing? GitHub doesn't let me.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Will merge with a bypass, let's keep an eye on it.

@tyxla tyxla merged commit 0ad32f9 into trunk Nov 3, 2025
39 of 43 checks passed
@tyxla tyxla deleted the fix/theme-build-issues branch November 3, 2025 10:01
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 3, 2025
@aduth aduth added the [Package] Theme /packages/theme label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Theme /packages/theme [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants