Theme: Add new caution color ramp #72782
Merged
+535
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Enhancement
Member
Author
|
@jameskoster Curious if you have any thoughts on the best way to document the distinction between "caution" and "warning" ? |
|
Size Change: +89 B (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
Contributor
|
Good question. Caution could be classified as "Heads-up, minor issue, or 'proceed carefully'" while Warning is for more serious or time-sensitive issues, that aren't full errors. Does that help? |
Member
Author
It does, thanks! How do you feel about how I approached this in 9ad7fc7, also incorporating documentation for the color token scheme more generally. (Acknowledging I used some AI assistance in drafting this, so it's worth a bit of extra scrutiny for anything I might have missed in my manual review) |
|
Flaky tests detected in a9f45e6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18974350383
|
jameskoster
reviewed
Oct 30, 2025
| | --------------------- | ------------------------------------- | | ||
| | `active` | Hovered, pressed, or selected state. | | ||
| | `disabled` | Non-interactive or unavailable state. | | ||
|
|
Contributor
There was a problem hiding this comment.
Does focus count as interaction? Some of our components can still be focused in disabled state.
Member
Author
There was a problem hiding this comment.
Does
focuscount as interaction? Some of our components can still be focused in disabled state.
Ideating with my AI friend, how does "inoperable" sound in place of "interactive"? As far as conveying the idea that the element likely won't receive clicks or keypresses, but could be focused.
Member
Author
|
@jameskoster I made some revisions to the descriptions based on your feedback in e19f37f |
jameskoster
approved these changes
Oct 31, 2025
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Acknowledging that we might want to finesse the seed colors later, this seems good to merge for now!
Co-Authored-By: James Koster <846565+jameskoster@users.noreply.github.com>
Co-Authored-By: James Koster <846565+jameskoster@users.noreply.github.com>
aduth
force-pushed
the
add/theme-caution-tokens
branch
from
e19f37f to
a9f45e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Expands on the work started in #72305 to create a new range of color tokens for "caution" states.
Why?
These are intended to be used in themed components to convey a distinct severity level within warning states, similar to what's seen in some other design systems (e.g. IBM Carbon).
How?
Testing Instructions
Verify in Storybook:
npm run storybook:devScreenshots or screencast