-
Notifications
You must be signed in to change notification settings - Fork 4.6k
DataViews: Keep icon-only buttons on mobile for bulk actions #72761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Keep icon-only buttons on mobile for bulk actions #72761
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch. PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk. |
Co-authored-by: lezama <migueluy@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
|
This PR has been backported manually at #72769 |
|
I think we should avoid icons altogether if we can. Thinking further ahead to the admin redesign some actions are going to be very hard to iconise like enabling/disabling auto-updates. Even today activating and deactivating templates don't have great icons. On mobile the problem is even worse because tooltips are inaccessible. Could we try a Menu here instead? |










What?
Follow up to #72501
Restores icon-only buttons on mobile for DataViews bulk actions.
Why?
PR #72501 changed bulk action buttons to show text labels, which works well on desktop but creates space constraints on mobile viewports where icon-only buttons are more appropriate.
How?
useViewportMatch( 'medium', '<' )to detect mobile viewportsTesting Instructions
Testing Instructions for Keyboard
Not applicable - no keyboard interaction changes.