Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 28, 2025

What?

Follow up to #72501

Restores icon-only buttons on mobile for DataViews bulk actions.

Why?

PR #72501 changed bulk action buttons to show text labels, which works well on desktop but creates space constraints on mobile viewports where icon-only buttons are more appropriate.

How?

Testing Instructions

  1. Open the Site Editor → Pages (or any DataViews implementation with bulk actions)
  2. Select multiple items to reveal bulk actions
  3. On desktop viewport: verify buttons show text labels
  4. Resize to mobile viewport (< 782px): verify buttons show icons only
  5. Verify actions without icons are not displayed on mobile

Testing Instructions for Keyboard

Not applicable - no keyboard interaction changes.

@lezama lezama requested a review from oandregal as a code owner October 28, 2025 22:59
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: lezama <migueluy@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Oct 29, 2025
@oandregal oandregal added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 29, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Oct 29, 2025
@oandregal oandregal enabled auto-merge (squash) October 29, 2025 07:33
@oandregal oandregal merged commit 1ae1d72 into WordPress:trunk Oct 29, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Oct 29, 2025
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 29, 2025
@github-actions
Copy link

There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch.

PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk.

# Checkout the wp/6.9 branch instead of trunk.
git checkout wp/6.9
# Create a new branch for your PR.
git checkout -b my-branch
# Cherry-pick the commit.
git cherry-pick 1ae1d72ad7d1cfd2547f55acc5c44ae1f908144e
# Check which files have conflicts.
git status
# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue
# Push the branch to the repository
git push origin my-branch
# Create a PR and set the base to the wp/6.9 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

oandregal added a commit that referenced this pull request Oct 29, 2025
Co-authored-by: lezama <migueluy@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
oandregal added a commit that referenced this pull request Oct 29, 2025
…#72769)

Co-authored-by: Miguel Lezama <lezama@gmail.com>
Co-authored-by: lezama <migueluy@git.wordpress.org>
@oandregal
Copy link
Member

This PR has been backported manually at #72769

@oandregal oandregal removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 29, 2025
@jameskoster
Copy link
Contributor

I think we should avoid icons altogether if we can. Thinking further ahead to the admin redesign some actions are going to be very hard to iconise like enabling/disabling auto-updates. Even today activating and deactivating templates don't have great icons. On mobile the problem is even worse because tooltips are inaccessible.

Could we try a Menu here instead?

@oandregal
Copy link
Member

oandregal commented Oct 29, 2025

This is the current state of text-based actions compared to what was shipped in 6.8:

  • Improving the list hover status for 6.9 would be great.
  • Bulk actions in mobile still use icons, but that's how they were working in 6.8. While it'd be nice to ship the long-term solution in 6.9, but given the time-constraints, I'd give this less priority.
  • The text-based actions take a lot of space, competing with other columns. I'd revisit this and try to find a solution like we have on the list (the space is not pre-assigned, but rather, when the action is visible, we overlap it on top of the row content). Again, nice to find the long-term solution for this in 6.9, but given the time-constraints, I'd give it less priority.
State 6.8 6.9
List: row hover Screenshot 2025-10-29 at 10 20 47 Screenshot 2025-10-29 at 10 20 55
Table Screenshot 2025-10-29 at 10 21 17 Screenshot 2025-10-29 at 10 21 23
Table: row hover Screenshot 2025-10-29 at 10 36 03 Screenshot 2025-10-29 at 10 36 14
Table: bulk actions (desktop viewport) Screenshot 2025-10-29 at 10 21 51 Screenshot 2025-10-29 at 10 21 44
Table: bulk actions (mobile viewport) Screenshot 2025-10-29 at 10 22 13 Screenshot 2025-10-29 at 10 27 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants