Notes: Fix block toolbar indicator logic #72736
Merged
+7
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
Size Change: -226 B (-0.01%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 44048ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18865344046
|
jasmussen
approved these changes
Oct 28, 2025
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice one. Works for me:
One detail to care about in the 7.0 cycle is the precise appearance of the avatar. In some of the later designs, there's a little inner gap between the circle and the avatar:
Just mentioning it as I notice it.
Thanks for the work!
Member
Author
|
Thanks for testing, @jasmussen! Yes, let's follow up on avatar design. Do you mind creating an issue? The feature now also uses global discussion settings. I'm not sure if it should depend entirely. For example, the avatar fallback comes from the site settings, but it might be better served by a "no avatar" SVG. While the Notes are built using comments, it's not the same as a general discussion. |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 28, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 35c2063 |
t-hamano
reviewed
Oct 28, 2025
Contributor
There was a problem hiding this comment.
LGTM!
In some of the later designs, there's a little inner gap between the circle and the avatar:
I believe this was addressed in #71917. However, I noticed that the padding between the circle and the avatar is transparent, resulting in the background behind it showing through. The avatar itself needs a background color. This can be addressed as a bug fix in the 6.9 release.
| Actual | Expected |
|---|---|
 |
 |
| } | ||
|
|
||
| // Comment avatar indicators. | ||
| .comment-avatar-indicator { |
Contributor
There was a problem hiding this comment.
Nit: Based on my testing, removing all of these styles should not cause any visual problems.
Contributor
|
Created an issue here! #72738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #72532
PR pushes following fixes for the block toolbar indicator component:
threadHasMoreParticipantsis counted. It should be based on unique participants per block note, not the total number of notes per post. Now we're also fetching all the notes - Notes: Load all records #72692.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast