Skip to content

iAPI: Fix derived state closures processing on client-side navigation #72725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 27, 2025
Merged

iAPI: Fix derived state closures processing on client-side navigation #72725

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa8f087
Fix PHP warning
DAreRodz Oct 27, 2025
212299f
Add failing test
DAreRodz Oct 27, 2025
97ff923
Do not evaluate getters during derivedStateClosures processing
DAreRodz Oct 27, 2025
bb98aef
Simplify check
DAreRodz Oct 27, 2025
710ef00
Add changelog entry
DAreRodz Oct 27, 2025
e1840e6
Fix PHPCS errors
DAreRodz Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix PHP warning
  • Loading branch information
@DAreRodz
DAreRodz committed Oct 27, 2025
commit fa8f08738168fb4bd3f5520fd01c6d18157f6bac
2 changes: 1 addition & 1 deletion packages/e2e-tests/plugins/interactive-blocks/router-navigate/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @phpcs:disable VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable
*/

if ( $attributes['disableNavigation'] ) {
if ( isset( $attributes['disableNavigation'] ) && $attributes['disableNavigation'] ) {
wp_interactivity_config(
'core/router',
array( 'clientNavigationDisabled' => true )
Expand Down