Skip to content

Template activation: allow duplicates of 'custom' plugin templates to be activated #72713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 28, 2025
Merged

Template activation: allow duplicates of 'custom' plugin templates to be activated #72713

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cf660f
Template activation: allow duplicates of 'custom' plugin templates to…
ellatrix Oct 27, 2025
436c959
Restore removing deactivate button for active registered templates
ellatrix Oct 27, 2025
8ce160b
Don't show active custom templates in the active view
ellatrix Oct 27, 2025
14c45b4
Fix pagination problem
ellatrix Oct 28, 2025
0499fb6
Fix typo
ellatrix Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't show active custom templates in the active view
  • Loading branch information
@ellatrix
ellatrix committed Oct 28, 2025
commit 8ce160bfd39c14a2e575055f83f8c07d5ca67504
46 changes: 32 additions & 14 deletions packages/edit-site/src/components/page-templates/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,37 +121,55 @@ export default function PageTemplates() {
return _active;
}, [ userRecords, staticRecords, activeTemplatesOption, activeTheme ] );

let _records;
let isLoadingData;
if ( activeView === 'active' ) {
_records = activeTemplates;
isLoadingData = isLoadingUserRecords || isLoadingStaticData;
} else if ( activeView === 'user' ) {
_records = userRecords;
isLoadingData = isLoadingUserRecords;
} else {
_records = staticRecords;
isLoadingData = isLoadingStaticData;
}

const records = useMemo( () => {
return _records.map( ( record ) => ( {
...record,
_isActive: !! activeTemplates.find(
( template ) => template.id === record.id
),
_isCustom:
// For registered templates, the is_custom field is defined.
function isCustom( record ) {
// For registered templates, the is_custom field is defined.
return (
record.is_custom ??
// For user templates it's custom if the is_wp_suggestion meta
// field is not set and the slug is not found in the default
// template types.
( ! record.meta?.is_wp_suggestion &&
! defaultTemplateTypes.find(
! defaultTemplateTypes.some(
( type ) => type.slug === record.slug
) ),
) )
);
}

let _records;
if ( activeView === 'active' ) {
// Don't show active custom templates in the active view.
_records = activeTemplates.filter(
( record ) => ! isCustom( record )
);
} else if ( activeView === 'user' ) {
_records = userRecords;
} else {
_records = staticRecords;
}
return _records.map( ( record ) => ( {
...record,
_isActive: activeTemplates.some(
( template ) => template.id === record.id
),
_isCustom: isCustom( record ),
} ) );
}, [ _records, activeTemplates, defaultTemplateTypes ] );
}, [
activeTemplates,
defaultTemplateTypes,
userRecords,
staticRecords,
activeView,
] );

const users = useSelect(
( select ) => {
Expand Down
Loading