Template activation: allow duplicates of 'custom' plugin templates to be activated #72713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -37 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/plugin-template-activation-custom
branch
from
1d6e4bb to
4b16298
Compare
ellatrix
commented
Oct 27, 2025
| return <Badge intent="error">{ item.theme }</Badge>; | ||
| }, | ||
| }; | ||
| return useMemo( |
Member
Author
There was a problem hiding this comment.
Just added useMemo here.
|
Flaky tests detected in 14c45b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18867527805
|
ellatrix
force-pushed
the
fix/plugin-template-activation-custom
branch
from
0d678b9 to
8ce160b
Compare
ellatrix
added
the
Backport to WP 6.9 Beta/RC
kmanijak
approved these changes
Oct 28, 2025
Contributor
kmanijak
left a comment
kmanijak
left a comment
There was a problem hiding this comment.
Thanks @ellatrix for the PR and followup fixes based on my testing! 🚀
I tested the PR from WooCoommerce perspective and:
- template edits from before activation are preserved
- templates can be edited, saved and user is prompt to activate the template
- custom templates show up in the editor
Looking good, let's merge!
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 28, 2025
… be activated (#72713) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: kmanijak <karolmanijak@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 551c3a0 |
tyxla
reviewed
Oct 31, 2025
Comment on lines
+181
to
+184
| if ( item.theme === activeTheme.stylesheet ) { | ||
| return <Badge intent="success">{ item.theme }</Badge>; | ||
| } | ||
| return <Badge intent="error">{ item.theme }</Badge>; |
Member
There was a problem hiding this comment.
Nit: we're creating 2 separate <Badge /> components, when we could have made just the intent prop have a conditional value.
|
|
||
| const activeLabel = item._isCustom | ||
| ? __( 'Active when used' ) | ||
| : __( 'Active' ); |
Member
There was a problem hiding this comment.
These might need context or a translator's comment. For example, in some languages, these words will have a gender, and it might depend on the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #72475. See #72580.
All registered templates were editable before: so you need to be able to duplicate and activate.
Example: the
Page No Titleis a custom template, which is in a sort of grey area in terms of "Active" status. I've opted for "Active when used" for custom templates, because they may be used for certain pages, and plugins may render templates their own way.Users can duplicate these templates (previously edit), which means this duplicate can now be activated and receive the "Active when used" status, while the original theme/plugin (registered) template will become "Inactive".
This PR essentially removes custom behavior for custom (ugh) templates: they can be activated, we just label the status differently.
Note
Plugins can opt-out of showing the special custom template status by adding the slug to
default_template_types. When added to this filter, these templates will now receive the regular "Active" status like theme templates types.Note
When plugins register templates that fit in the template hierarchy, they should not be marked as custom templates. This is currently a pre-6.9 limit where only a narrow set of template slugs are considered default templates. This is incorrect: any slug that matches the hierarchy should be considered a default template. When we fix this in the future, these templates will automatically no longer be marked as custom.
Why?
Backwards compatibility: All registered templates were editable before: so you need to be able to duplicate and activate.
It also simplifies things and makes things easy to reason about: all templates can be activated.
How?
Testing Instructions
When testing the 2025 theme:
When testing Woo:
TODO: add some e2e tests for these custom template flows.
Testing Instructions for Keyboard
Screenshots or screencast