Global Styles: Cleanup the previous global styles private exports in block-editor #72702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
ellatrix,
fabiankaegy and
juanmaguitar
as code owners
youknowriad
added
the
[Type] Code Quality
|
Size Change: -70 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
cleanup/global-styles-private-exports
branch
from
c03858a to
3a0603f
Compare
…block-editor package
youknowriad
force-pushed
the
cleanup/global-styles-private-exports
branch
from
3a0603f to
4466b0f
Compare
|
Flaky tests detected in 4466b0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18841303168
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some dead code ellimination/deduplication and some cleanup in the global styles code. This moves the "areGlobalStylesEqual" function to global-styles-engine package as well.
Testing Instructions