Skip to content

Build: Auto register styles from packages #72699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2025
Merged

Build: Auto register styles from packages #72699

merged 4 commits into from
Oct 28, 2025

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Oct 27, 2025

Related #72032

What

This continues the work on the build tool. This PR auto-registers styles (like we did scripts and modules before) based on the packages built in the current plugin.

Why?

  • Reduces maintenance burden - no need to manually update PHP registration code when adding/removing scripts
  • Improved DevX for plugin authors that would like to register scripts as well.

How?

  • Build process now collects styles metadata during bundling
  • Uses PHP templates to generate two files:
  • build/styles/index.php - module registry data array
  • build/styles - registration logic with hooks

Testing Instructions

E2E tests should pass (scripts are used everywhere)

@youknowriad youknowriad self-assigned this Oct 27, 2025
@youknowriad youknowriad added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad youknowriad added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Oct 27, 2025
@youknowriad youknowriad force-pushed the add/auto-register-styles branch from 35501e8 to 41fcd34 Compare October 27, 2025 13:24
@youknowriad youknowriad force-pushed the add/auto-register-styles branch from 41fcd34 to ebd5b18 Compare October 28, 2025 07:12
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Flaky tests detected in 3463767.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18867656511
📝 Reported issues:

@youknowriad youknowriad merged commit 7b0c350 into trunk Oct 28, 2025
34 checks passed
@youknowriad youknowriad deleted the add/auto-register-styles branch October 28, 2025 08:23
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@youknowriad youknowriad

Labels

No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

Gutenberg 22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowriad