-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix build command for tokens package on Windows #72605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated the bug on my Windows machine and tested this fix. Build runs to completion with this fix.
|
Using Prettier's debugging flag Before: (on macOS) On Windows, I'm guessing the expansion doesn't happen and the arguments come through verbatim like After: |
|
Size Change: 0 B Total Size: 2.19 MB ℹ️ View Unchanged
|
What?
Fixes an issue where the
@wordpress/themepackagebuildscript fails on Windows.Follow-up to #72305
Why?
So that builds will pass.
Related Slack thread: https://wordpress.slack.com/archives/C02RQBWTW/p1761156071684359
How?
Avoids
*which expands in non-Windows environment. The result should be the same by passing just the directory names.Testing Instructions
npm run --workspace @wordpress/theme buildshould not fail.Also check that making formatting changes to the affected files in
packages/theme/src/prebuiltand then rerunning the command will apply Prettier formatting as expected.