Skip to content

ComboboxControl: Display reset button only if there's a value #72595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 27, 2025
Merged

ComboboxControl: Display reset button only if there's a value #72595

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3517b34
ComboboxControl: Show reset button only when there is a value
juanfra Oct 22, 2025
5fd3181
Fix reset button tests.
juanfra Oct 22, 2025
e7e201d
Add tests for the reset button when value is not set and when allowRe…
juanfra Oct 22, 2025
fb3ef66
Update changelog link with PR reference.
juanfra Oct 22, 2025
5bf1332
Merge branch 'trunk' into fix/72522-combobox-reset-when-value
juanfra Oct 25, 2025
9f85e15
Hide reset where there is technically a value set but it isn't visibl…
juanfra Oct 25, 2025
9055397
Remove `allowReset: false` from ComboboxControl story default args.
juanfra Oct 25, 2025
f1dcc83
Remove outdated test.
juanfra Oct 25, 2025
635ff1c
Remove value set via props as we're simulating the value picking.
juanfra Oct 25, 2025
5b75f8a
Add test to confirm that resetButton is not in document.
juanfra Oct 25, 2025
1657aa3
Update tests.
juanfra Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests.
  • Loading branch information
@juanfra
juanfra committed Oct 25, 2025
commit 1657aa347e7e847b511e95c1d120d75c85604470
5 changes: 2 additions & 3 deletions packages/components/src/combobox-control/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ describe.each( [
<Component
options={ timezones }
label={ defaultLabelText }
value={ timezones[ 0 ].value }
allowReset={ false }
/>
);
Expand Down Expand Up @@ -427,7 +426,6 @@ describe.each( [
<Component
options={ timezones }
label={ defaultLabelText }
value={ targetOption.value }
allowReset
/>
);
Expand All @@ -454,6 +452,7 @@ describe.each( [
// Pressing Enter/Return resets the input.
await user.keyboard( '{Enter}' );

expect( resetButton ).not.toBeInTheDocument();
expect( input ).toHaveValue( '' );
expect( input ).toHaveFocus();
} );
Expand All @@ -466,7 +465,6 @@ describe.each( [
<Component
options={ timezones }
label={ defaultLabelText }
value={ targetOption.value }
allowReset
/>
);
Expand All @@ -493,6 +491,7 @@ describe.each( [
// Pressing Spacebar resets the input.
await user.keyboard( '[Space]' );

expect( resetButton ).not.toBeInTheDocument();
expect( input ).toHaveValue( '' );
expect( input ).toHaveFocus();
} );
Expand Down
Loading