Skip to content

add: Missing JSON Schema for blocks. #72590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2025
Merged

add: Missing JSON Schema for blocks. #72590

merged 3 commits into from
Oct 27, 2025

Conversation

@levinbaria
Copy link
Contributor

@levinbaria levinbaria commented Oct 22, 2025

What?

Closes #72562

This PR adds missing block entries to the JSON theme schema so these core blocks are exposed to theme-level settings and styles:

  • core/accordion
  • core/accordion-heading
  • core/accordion-item
  • core/accordion-panel
  • core/math
  • core/post-time-to-read
  • core/term-count
  • core/term-name
  • core/term-template
  • core/terms-query

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @EldarAgalarov.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: EldarAgalarov.

Co-authored-by: levinbaria <levinbaria@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you move the newly added properties so that they are in the correct alphabetical order? Also, this needs to be updated as well:

gutenberg/schemas/json/theme.json

Line 2266 in 074731f

"properties": {

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Oct 22, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Oct 22, 2025
@t-hamano t-hamano added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 22, 2025
@levinbaria
Copy link
Contributor Author

levinbaria commented Oct 25, 2025

Thanks for the feedback @t-hamano,

I have made changes accordingly.

t-hamano
t-hamano reviewed Oct 25, 2025
View reviewed changes
t-hamano
t-hamano approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano merged commit fb0cb96 into WordPress:trunk Oct 27, 2025
42 of 43 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Oct 27, 2025
@github-actions github-actions bot added this to the Gutenberg 22.0 milestone Oct 27, 2025
@github-actions github-actions bot removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 27, 2025
gutenbergplugin pushed a commit that referenced this pull request Oct 27, 2025
@levinbaria @t-hamano @gutenbergplugin
add: Missing JSON Schema for blocks. (#72590)
be4fc27 
* add: Missing JSON Schema for blocks.

* Fix: Made block in alphabetical order and other changes.

* Feedback changes.

Unlinked contributors: EldarAgalarov.

Co-authored-by: levinbaria <levinbaria@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: be4fc27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

Assignees

No one assigned

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Type] Developer Documentation Documentation for developers

Projects

WordPress 6.9 Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 22.0

Development

Successfully merging this pull request may close these issues.

Time To Read/Word Count & Math Blocks: Missing JSON Schema

2 participants

@levinbaria @t-hamano