Persist credentials when cherry-picking commits to a release branch #72556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
I'll handle manually cherry-picking any missed commits now. It's probably best to try to keep them in order to avoid conflicts, so I think the sooner the better 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See the slack convo - https://wordpress.slack.com/archives/C02QB2JS7/p1761097846014379.
Changes the
persist-credentialsoption back totruefor the cherry-pick action.Why?
It looks like this was changed to
falseincorrectly in #69126. The credentials are needed in a later step to perform the cherry-picking.There were also some similar issues that arose from the same PR - (#70007, #70058). It looks like the cherry-pick action possibly wasn't tested after that PR was merged (I expect it's quite difficult to test these actions).