Size Change: +133 B (+0.01%)

Total Size: 2.19 MB

_{compressed-size-action}

Flaky tests detected in ea68b2d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18738557668
📝 Reported issues:

• [Flaky Test] correctly applies dynamic allowed blocks restrictions #51220 in /test/e2e/specs/editor/plugins/inner-blocks-allowed-blocks.spec.js
• [Flaky Test] should refresh the page when stylesheet loading fails #71722 in /test/e2e/specs/interactivity/router-styles.spec.ts

Oh, I think we overlooked template-locked rendering at some point. I think v1 should enable the feature only when the editor is rendering just the post content.

cc @t-hamano, @adamsilverstein

Clever idea to make the thread area scrollable. I'll give it a try to see how it feels.

@jasmussen - how do you feel about this proposed solution to the overflow issue?

Nice work. There's some potential here. Here's a quick GIF:

It's a slightly unusual behavior but it might be good as a bugfix if the code is simple. But there are a couple of pieces to it. This may ultimately need to be a mainly tech-driven solution, as far as finding the beta-phase bugfix that is the simplest and most solid, that we have confidence in. Whether that's this one, or Adam's suggestion of extending the canvas, both seem to directly address the edgecase of long comments.

What are your general thoughts on this?

Two things though. If we go with this route, we should also apply a min-height, so the resting state looks balanced:

Here, the bottom padding of the input field, and the bottom padding of the note container itself, should ideally be the same all the way around.

Another thing, when notes go really long in Google Docs, they get elided after the first several lines of text like so:

We have here a mockup for how that could look for us:

It's unclear if that's possible in the beta period, it can probably wait, but it is an ingredient of the puzzle here.

If we go with this route, we should also apply a min-height, so the resting state looks balanced:

Good catch. This fix is in ea68b2d – just needed some flex-shrink: 0.

I’ve made #72598 for getting the padding appender working in the Site editor, and that would solve one of the problem cases for this approach. Given we could land that for 6.9 and we also do as George suggested #72547 (comment) then this could do, I think.

I think v1 should enable the feature only when the editor is rendering just the post content.

I agree, let's disable Notes until the Notes supports the site editor and templates.

This worked well in my testing. Should we use this instead of #72454?

Thanks for your work here @stokesman - we have decided to go with a different solution, see #72811 - appreciate any feedback you have on that ticket.