Terms Query: Show nested terms toggle when inheriting #72510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Enhancement
|
Size Change: -19 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Oct 21, 2025
packages/block-library/src/terms-query/edit/inspector-controls/inherit-control.js
Outdated
Show resolved
Hide resolved
Contributor
|
We need to also update the php logic for fetching the proper terms. Currently we cannot use |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
Thanks @ntsekouras. I've had a go at addressing this in 3752755. I think it's working in my testing on both templates and posts/pages, but it would be good to have more testing. I noticed that the |
mikachan
commented
Oct 21, 2025
| @@ -0,0 +1,88 @@ | |||
| /** | |||
Member
Author
There was a problem hiding this comment.
This useCurrentTerm is very similar to the useArchiveLabel, useTermDescription, and useTermName hooks, so I think we should consolidate this functionality as much as possible in a follow-up.
Contributor
There was a problem hiding this comment.
This functionality had some heavy discussion in #72300 which ultimately didn't get merged. There are issues if taxonomy slugs contain hyphens, because the template slug does not include additional separators. Historically WordPress applies a template if it matches certain criteria but doing the reverse is tricky.
Contributor
Member
Author
There was a problem hiding this comment.
Thanks both, sounds like something that would be best in its own PR. I've removed the changes to the editor logic in 546598a.
ntsekouras
added
[Type] Bug
cr0ybot
approved these changes
Oct 22, 2025
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 23, 2025
Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: cr0ybot <cr0ybot@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: a66a55c |
Member
|
Thanks for handling it @mikachan 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses #72380 (comment)
This PR allows the "Show nested terms" toggle control to show when the Terms Query is inheriting the current query.
Why?
Gives the user more control over which terms are displayed in default/inherit mode.
How?
Removes the logic for only showing the "Show nested terms" toggle when in custom mode.
Testing Instructions
Screenshots or screencast
cc @cr0ybot