Storybook: Fix dev script
#72487
Merged
Storybook: Fix dev script
#72487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Oct 20, 2025
| "start": "npm run dev", | ||
| "prestorybook:build": "npm run build", | ||
| "storybook:build": "storybook build -c ./storybook -o ./storybook/build", | ||
| "prestorybook:dev": "npm run build", |
Member
Author
There was a problem hiding this comment.
The pre script is no longer necessary after the new dev script (bin/dev.mjs).
Member
There was a problem hiding this comment.
I wondered why the pre-script wasn't enough to prevent the error (i.e. have a single built pass before the Storybook dev command starts), but then I noticed the build script clears existing build artifacts before starting.
What if we just didn't do that?
Member
Author
There was a problem hiding this comment.
That's technically possible I guess, but it will still be slower than the marker file approach because we'd need to wait for a full build before initiating the Storybook command.
Not sure why we do a pre-clean in the dev script but not the build script though.
|
Size Change: 0 B Total Size: 2.2 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 5a9b8c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18650837576
|
youknowriad
reviewed
Oct 20, 2025
| "storybook:dev": "concurrently \"npm run dev\" \"storybook dev -c ./storybook -p 50240\"", | ||
| "storybook:e2e:dev": "concurrently \"npm run dev\" \"storybook dev -c test/storybook-playwright/storybook -p 50241\"", | ||
| "storybook:dev": "concurrently \"npm run dev\" \"wait-on .dev-ready && storybook dev -c ./storybook -p 50240\"", | ||
| "storybook:e2e:dev": "concurrently \"npm run dev\" \"wait-on .dev-ready && storybook dev -c test/storybook-playwright/storybook -p 50241\"", |
Contributor
There was a problem hiding this comment.
I don't like that typescript is forcing us to have this marker. I wonder if we can simplify and run things sequentially or something.
Member
Author
There was a problem hiding this comment.
Yeah, it could be possible to break down the dev/build scripts into smaller scripts. That itself may have complexity trade-offs though.
youknowriad
approved these changes
Oct 20, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #72488
What?
Fixes the
storybook:devcommand so it doesn't fail on race conditions.Why?
The
npm run storybook:devcommand currently fails with these kind of errors:The
npm run devcommand andstorybook devcommand are run concurrently, and it happens that with our new esbuild setup, the Storybook side of the build starts while the packages are still mid-build. We need a way to signal when exactly the initial package builds are ready.How?
Create a temporary marker file when the initial build is ready, and watch for that file before we start the Storybook dev command.
Testing Instructions
npm run storybook:devshould work.