-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Button: Ensure that icons don't shrink #72474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
jasmussen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you!
What?
Prevents icon buttons from shrinking their icons when the button content wants to overflow their containers.
Why?
We don't want icons to be shrunken down, especially if a subtle shrink causes a developer to not notice an overflow.
How?
Add a
flex-shrink: 0to the icon element.Testing Instructions
You can either use this story for testing, or simply change the width of a
<Button icon={ foo } text="foo" />in dev tools.Story for testing
Screenshots or screencast