Skip to content

Fix empty url value from unbinding entity from inspector sidebar #72447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2025
Merged

Fix empty url value from unbinding entity from inspector sidebar #72447

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
167d316
Fix focus loss on unsync and edit from navigation link inspector
jeryj Oct 17, 2025
d59ed0a
Fix empty url value from unbinding entity from inspector sidebar
jeryj Oct 17, 2025
034082c
Update test to match new behavior
jeryj Oct 17, 2025
0b29a12
Fix unit tests
jeryj Oct 17, 2025
0d5671e
Add and edit comments
jeryj Oct 20, 2025
60068c1
Update unit test to use userEvents
jeryj Oct 20, 2025
ce74a66
Update lastURLRef within the useEffect as a safeguard
jeryj Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix focus loss on unsync and edit from navigation link inspector 
The unsync and edit button enables the disabled input and removes the button that was focused. This causes a focus loss.

I added:
- Ref for the input
- Ref for knowing if we should focus on next render (we can't focus immediately, as the input is disabled and cannot receive focus)
- useEffect to check if we should send focus to the input when hasUrlBinding changes
  • Loading branch information
@jeryj
jeryj committed Oct 20, 2025
commit 167d31691f327e58bd2718159e086854ce4b2a5a
2 changes: 2 additions & 0 deletions packages/block-library/src/navigation-link/shared/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ export function Controls( { attributes, setAttributes, clientId } ) {
};

useEffect( () => {
// Checking for ! hasUrlBinding is a defensive check, as we would
// only want to focus the input if the url is not bound to an entity.
if ( ! hasUrlBinding && shouldFocusURLInputRef.current ) {
urlInputRef.current?.focus();
}
Expand Down