Skip to content

Fix focus loss from unsync and edit button in navigation link inspector sidebar #72436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

Fix focus loss from unsync and edit button in navigation link inspector sidebar #72436

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9c5a78
Fix focus loss on unsync and edit from navigation link inspector
jeryj Oct 17, 2025
d1bed8d
Make url input focus code more defensive
jeryj Oct 17, 2025
a2cea97
Update packages/block-library/src/navigation-link/shared/controls.js
jeryj Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/block-library/src/navigation-link/shared/controls.js 
Co-authored-by: Ben Dwyer <ben@scruffian.com>
  • Loading branch information
@jeryj @scruffian
jeryj and scruffian authored Oct 17, 2025
commit a2cea971cb3fcd3222261d11f3b7d2a7a6e3fa56
4 changes: 2 additions & 2 deletions packages/block-library/src/navigation-link/shared/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ export function Controls( { attributes, setAttributes, clientId } ) {
icon={ unlinkIcon }
onClick={ () => {
unsyncBoundLink();
// focus management to send focus to the URL input
// on next render after disabled state is removed
// Focus management to send focus to the URL input
// on next render after disabled state is removed.
shouldFocusURLInputRef.current = true;
} }
aria-describedby={ helpTextId }
Expand Down
Loading