Skip to content

Fit text: update help text to clarify override of font-size #72303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

Fit text: update help text to clarify override of font-size #72303

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3723964
fit text issue
sidharthpandita1 Oct 13, 2025
e8a62f5
Changes made
sidharthpandita1 Oct 16, 2025
65ef373
Changes made as asked
sidharthpandita1 Oct 22, 2025
4c41b48
Update packages/block-editor/src/hooks/fit-text.js
t-hamano Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fit text issue
  • Loading branch information
@sidharthpandita1
sidharthpandita1 committed Oct 13, 2025
commit 3723964974534ff970263baf24d6452dff4f11e5
4 changes: 3 additions & 1 deletion packages/block-editor/src/hooks/fit-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ export function FitTextControl( {
help={
fitText
? __( 'Text will resize to fit its container.' )
: __( 'Resize text to fit its container.' )
: __(
Copy link
Contributor

@ntsekouras ntsekouras Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think it's better to update the above help message to something like Text will resize to fit its container. Noting that any existing font size setting is overridden..

@jasmussen or @jorgefilipecosta any suggestions for better copy?

Copy link
Contributor

@jasmussen jasmussen Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, good instincts, good feedback.

Absent larger changes, yes I think a good and clear help message can work. One instinct would be

The text will resize to fit its container, overriding any specified font size.

'Font size setting is overriden when enabled'
)
}
/>
</ToolsPanelItem>
Expand Down
Loading