Fit text: update help text to clarify override of font-size #72303
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
changed the title
ntsekouras
added
[Type] Enhancement
| fitText | ||
| ? __( 'Text will resize to fit its container.' ) | ||
| : __( 'Resize text to fit its container.' ) | ||
| : __( |
There was a problem hiding this comment.
Thanks for the PR!
I think it's better to update the above help message to something like Text will resize to fit its container. Noting that any existing font size setting is overridden..
@jasmussen or @jorgefilipecosta any suggestions for better copy?
There was a problem hiding this comment.
Good PR, good instincts, good feedback.
Absent larger changes, yes I think a good and clear help message can work. One instinct would be
The text will resize to fit its container, overriding any specified font size.
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
Now that #72533 has been merged, when font size or fit text is enabled, the other setting is reset. So, how about making the help text a bit clearer in this PR? For example, "Resize text to fit its container. When enabled, font size settings are reset". |
|
How about:
|
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I think we can backport this PR to the 6.9 release, but I'd appreciate any second feedback.
t-hamano
added
the
Backport to WP 6.9 Beta/RC
|
It clarifies now-incorrect help text, I'd think it is spiritually a bugfix. |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
added
Backported to WP Core
* fit text issue * Changes made * Changes made as asked * Update packages/block-editor/src/hooks/fit-text.js --------- Co-authored-by: sidharthpandita1 <sidharthpandita@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: af65443 |
4 participants
closes:-#72219.
What?
Adds clarification to the Fit text control’s help text, explaining that when enabled, it overrides the Font Size setting.
Why?
To prevent confusion for users who might think the Font Size control isn’t working when Fit text is active.
This implements the reviewer’s suggestion to clarify behavior without connecting the two controls in code.
How?
Updated the help text in fit-text.js → FitTextControl component to state that Font Size settings are ignored when Fit text is enabled.
Before:
“Text will resize to fit its container.”
After:
“Text will resize to fit its container and override font size settings.”
Related Issue / PR:
Fixes minor UX feedback from reviewer on #72219.