Skip to content

Block Comments: Graduate Block Level Commenting from Experiments#72181

Closed
roseg43 wants to merge 5 commits intoWordPress:trunkfrom
roseg43:feat/graduate-block-commenting-from-experiments
Closed

Block Comments: Graduate Block Level Commenting from Experiments#72181
roseg43 wants to merge 5 commits intoWordPress:trunkfrom
roseg43:feat/graduate-block-commenting-from-experiments

Conversation

@roseg43
Copy link
Copy Markdown
Contributor

@roseg43 roseg43 commented Oct 8, 2025

Graduates the Block Commenting feature from experimental to compat for 6.9.

What?

Closes #71826

This PR moves all Block Comments-related code located in lib/experimental to lib/compat/wordpress-6.9. Additionally, it removes all experimental flags for conditionally enabling Block Comments functionality.

Why?

From #71826 :

The “Collaboration: add block level comments” feature is currently listed under Gutenberg > Experiments as an opt-in setting (“Enables multi-user block level commenting.”). For WordPress 6.9, this feature should be graduated from Experiments so that it is enabled by default for all Gutenberg users and no longer controlled from the Experiments settings page.

While the feature should be active by default, developers could perhaps still be able to disable it via a filter (or potentially a UI toggle elsewhere in settings), but it should no longer be presented as an experimental option.

How?

This PR executes the steps outlined in this comment:

  • Remove all logic that checks for experimental flags on the Block Commenting feature before enabling the feature
  • Migrate all Block Commenting related code into the compat folder for the WordPress version being targeted.
  • Ensure any experimental or __unstable prefixes are removed, or that the API is moved to a private API.

Testing Instructions

Confirm all commenting functionality is available

  1. Open a post or a page.
  2. Confirm that block commenting functionality is available, and no functionality has been altered from the current working feature.

Confirm the toggle option to enable the feature experiment has been removed

  1. Go to the Gutenberg > Experiments view in the Admin
  2. Confirm that no option is present to enable/disable Block Comments.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: roseg43 <gabertronic@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@roseg43
Block Comments: Remove feature toggle option from Experiments setting…
8872930 
…s view.

Additionally, remove experimental flags and conditionals from Block Comments test code.
@jeffpaul jeffpaul added [Type] Enhancement A suggestion for improvement. [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Oct 8, 2025
@jeffpaul jeffpaul mentioned this pull request Oct 8, 2025
Closed
@Mamaduka Mamaduka self-requested a review October 8, 2025 18:50
fabiankaegy
fabiankaegy approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here looks good to me 👍

I've tested the feature and it works 👍

Image

I don't have enough insight into the overall feature direction at this point. To me, it still feels a bit unpolished (especially in the UI flows) but again I haven't been involved at all in the 6.9 scope planning etc :)

Would love a final confirmation from someone like @Mamaduka :) before we merge 👍

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 8, 2025

I think a couple more enhancements still need to go in before we graduate this feature from experimental.

@fabiankaegy fabiankaegy self-requested a review October 8, 2025 19:12
@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 14, 2025

Hi, @roseg43

Would you be able to rebase this branch and resolve merge conflicts?

We should also create a core sync PR and ticket. I'm happy to handle that.

@Mamaduka Mamaduka mentioned this pull request Oct 14, 2025
Closed
4 tasks
@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Oct 14, 2025

@Mamaduka i believe @roseg43 is offline for the next couple of days, so if you (or alternatively @adamsilverstein @poojabhimani12) are able to resolve conflicts to get this ready for merge that's probably best.

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 14, 2025

@jeffpaul, I'll handle it. Though I might need to create a new PR, it depends on whether I can push to the forked branch.

@Mamaduka Mamaduka mentioned this pull request Oct 15, 2025
Merged
@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 15, 2025

Here's the new PR - #72344.

@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Oct 15, 2025

@Mamaduka we can likely close this PR now as yours has been merged, yeah?

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 15, 2025

Thanks for the reminder, @jeffpaul and thanks, @roseg43, for starting the process.

@Mamaduka Mamaduka closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@roseg43 roseg43

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Graduate Block Level Commenting from Experiments

4 participants

@roseg43 @Mamaduka @jeffpaul @fabiankaegy