Dataviews: Delete the isDestructive prop from the actions#72111
Merged
oandregal merged 3 commits intoWordPress:trunkfrom Oct 8, 2025
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
oandregal
approved these changes
Oct 8, 2025
oandregal
reviewed
Oct 8, 2025
epeicher
deleted the
update/dataviews-remove-is-destructive-action-type
branch
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…72111) Co-authored-by: epeicher <epeicher@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Deletes the
isDestructiveprop from the dataviews Actions API as it is not required.Why?
The
isDestructiveprop is used to set a red color to the primary action's icon, but that is not required according to the new design guidelines, as that will be included in the rendered Modal, that is created by the consumer. So that prop is not required anymore.How?
Reviewing all the occurrences of the
isDestructiveprop from the code and the docs.Testing Instructions
npm run storybook:devisDestructiveprop